Problem/Motivation

While the credit checkboxes have improved things a lot already in properly giving credit, there is still the issue that on average posting an even unrelated or out-of-scope patch to an issue will get review credit, while a long and thorough "Architecture / Code / DX / UX / AX / Design / Performance / ..." review that took several hours to create might not.

Core committers and project maintainers have improved on that, but it is still not possible to say "I deserve commit credit for this." besides nagging or writing proposed commit messages, which is all not what the goal of the improved commit credit widget was.

To sum it up in a Quote:

A lot of people don't review because review != credit, they could jump in with a 5 second reroll and get that :D.

Proposed resolution

- Add a special "I posted a review (Code / UX / AX / DX / TX / Design / Architecture / Performance / ... )" checkbox and count it like patch files.

Yes, it is possible to abuse it, but:

a) Commit credit can still be taken if someone is found abusive.
b) It is already possible to "game" the system with uploading images, unrelated changes, 5 min re-rolls, etc.

This will hopefully motivate more people on giving good reviews and it will ensure that if someone worked on e.g. performance profiling for days or re-reviewed a patch again and again, they will get the commit credit.

Remaining tasks

- Do it.

User interface changes

- Added a new checkbox and a new column.

API changes

- None (as far as I can see).

Comments

joshuami’s picture

Category: Task » Feature request
Priority: Major » Normal
Issue tags: +drupal.org profile improvements
Related issues: +#2230579: [meta] Allow crediting reviewers (and other non-coders) as first-class contributors

@fabianx, I like this idea a lot. (We talked about it a bit at DrupalCon Los Angeles. It would be an opportunity to tie in to the issue/commit credit UI and help maintainers give credit to users that provided significant help in getting an issue resolved.

There may be some overlap between this feature request and #2230579: [meta] Allow crediting reviewers (and other non-coders) as first-class contributors. We'll need to resolve that overlap, but that seems feasible.

tim.plunkett’s picture

a) Commit credit can still be taken if someone is found abusive.

Not true until #2501421: Cannot uncheck people who submitted patches from the issue credit UI is fixed.

YesCT’s picture

This sounds like #2489964: Reputation system for Drupal.org to me. ... or the issue where @tkoleary worked with @tvn on a UI for marking what kind of contribution it was... but I'm having trouble finding that other issue... [edit:] oh, maybe it was #2230579-14: [meta] Allow crediting reviewers (and other non-coders) as first-class contributors which was already referenced here.

Fabianx’s picture

#3: Yes, and no:

This is purely for the person doing reviews.

Maybe I should attach lengthy reviews as files instead? :p

( The problem is: I might just make a comment: "This is RTBC." I might have spent hours with the patch or just quickly glanced over it. Only I can know if what I did deserve commit credit or not ...)

No, I think this is the right move.

webchick’s picture

"This is RTBC" doesn't actually move the issue forward to completion nearly so as much as "I looked into this for several hours, tried this and that and this, wasn't able to break it. RTBC." so I think it's ok to encourage more detailed comments.