[D7] ImageCircleSlider

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxajalan0652500887git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi, ajalan065

First of all you should set normal title in this issue in format: [D7] Your module name
Also add to issue body link to git for your project.

Also there are problems with default branch of git:
There is still a master branch, make sure to set the correct default branch: https://www.drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in https://www.drupal.org/node/1127732

You should remove working files from git repo: ./Readme.txt~

Also move this code to function which call slider in your module:

drupal_add_js((drupal_get_path('module', 'imagecircleslider') . '/js/jquery.tinycircleslider.js') , 'external');
drupal_add_js((drupal_get_path('module',  'imagecircleslider') . '/js/slider.js') , 'external');
drupal_add_css((drupal_get_path('module', 'imagecircleslider') . '/css/circleslider.css') ,array('type' => 'external')) ;

Why you load 2 versions of jquery in imagecircleslider-view.tpl.php? Consider to use jquery_update module depency.

<script type="text/javascript" src="//code.jquery.com/jquery-latest.min.js"></script>
<script type="text/javascript" src="https://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js"></script>

Also please fix Drupal code standards: https://www.drupal.org/node/318

You can check coding standards with this service: http://pareview.sh

You should post link to your project git in first message.

Hey ajalan065,

Great work. Thanks for your contribution.

I havent gone through the functionality of the project. I have just reviewed your code and below are my findings:

1. There are two readme files in your code repository, there should be only one readme file.
2. Comment over here should be Implements hook_theme().
3. I didnt got the use of hook_library in your module, why it is required ?
4. You have added same js files couple of times in your views.inc and .module file, you should remove the duplicated code from .module file
5. There is oneimagecircleslider.tpl.php file, I don't think this is being used anywhere, correct me if I am wrong. You should remove this tpl file.

Please fix the above issues.

Hi ajalan065,

Take a look on imagecircleslider-field.tpl.php file.
There is wrong closing of </section>.
In line 27 it should </div> and </section> would be in line 28.

You readme file name should be README.txt instead of Readme.txt

1. Remove unnecessary comments here, and here, and here and here and here.
2. Save the result of drupal_get_path('module', 'imagecircleslider') into constance and use it in all places where the value is needed. For example:
   

   define('IMAGECIRCLESLIDER_MODULE_PATH', drupal_get_path('module', 'imagecircleslider'));
   

3. No need to wrap first argument of function by brackets.
4. Get the path to library by libraries_get_path('library') instead of hardcoded path.
5. Replace array_key_exists() by isset() here.
6. Wrong hook comment here.
7. Fix code indention here.
8. Unnecessary variable $items here. Just put the $variables['item'] as first argument to foreeach.

That look like nice but minor improvements and are not application blockers, anything else that you found or should this be RTBC instead?

I think 4 item is not a minor. Library can be placed anywhere, not only in "sites/all".

That would be a standard bug report, no security issue, no licensing violation, no heavy API misuse - so should not hold up this application.

Hi ajalan065,

Module looks good to me. Few minor change as an extension of what BROKEN has pointed out in https://www.drupal.org/node/2502333#comment-10057474.

1. No need of Else statement, if the library is present library_get_path will give you the path here.
2. Move this code to a function and the use this function.

if (module_exists('libraries') && function_exists('libraries_get_path')) {
    $jslib = libraries_get_path('imagecirclesliderlib') . '/js';
  }

3. You have defined the library with machine name "imagecircleslider" here

and you are trying to get "imagecirclesliderlib" in the above code. Please fix.

Looks good to me. I think we can now move it to RTBC.

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2535206

Project 2: https://www.drupal.org/node/2502333

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.