Hi, according to https://www.mapbox.com/help/attribution/ attribution for both MapBox and OSM is required. While this module sets the attributionControl to TRUE in its definition, it doesn't then set it accordingly (I guess it should be defined in the earth layer options:
'options' => array('attribution' => '')
I'll try to come up with a patch later on.

CommentFileSizeAuthor
#7 interdiff-mapbox_and-2502259-5-7.txt191 bytesbrockfanning
#7 mapbox_and-2502259-7.patch2.79 KBbrockfanning
#6 interdiff-mapbox_and-2502259-5-6.txt189 bytesbrockfanning
#6 mapbox_and-2502259-6.patch2.79 KBbrockfanning
#5 mapbox_and-2502259-5.patch2.79 KBbrockfanning
#3 openstreetmap_credits-2502259-3.patch3.13 KBbellesmanieres
#2 openstreetmap_credits-2502259-2.patch2.81 KBbellesmanieres
#1 openstreetmap_credits-2502259-1.patch2.87 KBbellesmanieres
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bellesmanieres’s picture

bellesmanieres CreditAttribution: bellesmanieres commented
Status: Active » Needs review
FileSize
openstreetmap_credits-2502259-1.patch2.87 KB

Patched attached to comply with the Terms of Use.

bellesmanieres’s picture

bellesmanieres CreditAttribution: bellesmanieres commented
FileSize
openstreetmap_credits-2502259-2.patch2.81 KB

Rerolled the patch to directly use an a tag instead of l() to avoid encoding issues.

bellesmanieres’s picture

bellesmanieres CreditAttribution: bellesmanieres commented
FileSize
openstreetmap_credits-2502259-3.patch3.13 KB

Oops, incomplete one. Re-attaching the right one.

attiks’s picture

attiks CreditAttribution: attiks at Attiks commented
Status: Needs review » Reviewed & tested by the community

Looks good to me

brockfanning’s picture

brockfanning CreditAttribution: brockfanning commented
FileSize
mapbox_and-2502259-5.patch2.79 KB

This doesn't seem to apply anymore, so here is a re-roll.

brockfanning’s picture

brockfanning CreditAttribution: brockfanning commented
FileSize
mapbox_and-2502259-6.patch2.79 KB
interdiff-mapbox_and-2502259-5-6.txt189 bytes

A minor tweak to add a space before "Improve this map".

brockfanning’s picture

brockfanning CreditAttribution: brockfanning commented
FileSize
mapbox_and-2502259-7.patch2.79 KB
interdiff-mapbox_and-2502259-5-7.txt191 bytes

Oops, a single space wasn't enough. Another try.

tobiberlin’s picture

tobiberlin
Primary language German
Location Berlin, Germany
CreditAttribution: tobiberlin as a volunteer commented

Patch from #7 works for me