New facebook video urls are not correctly recognized.

Currently handled urls:

https://www.facebook.com/lorem_ipsum?v=123456789
https://www.facebook.com/lorem_ipsum?video_id=123456789

But my video urls look like this:

https://www.facebook.com/lorem_ipsum/videos/123456789/?permPage=1
https://www.facebook.com/lorem_ipsum/videos/vb.385607554910385/123456789/?type=1&theater
CommentFileSizeAuthor
#4 facebook_url_fix-2502205-4.patch877 bytesidflood
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idflood’s picture

idflood CreditAttribution: idflood commented
Issue summary: View changes
idflood’s picture

idflood CreditAttribution: idflood commented
Issue summary: View changes
idflood’s picture

idflood CreditAttribution: idflood commented

I think I'v found a regular expression working on all urls:

(?:.*)(?:v=|video_id=|videos\/|videos\/v.\.\d+\/)(\d+).*

http://www.regexr.com/3b5rr

Patch following.

idflood’s picture

idflood CreditAttribution: idflood at Stimul.ch commented
Status: Active » Needs review
FileSize
facebook_url_fix-2502205-4.patch877 bytes

Here is a patch with the new regular expression.

  • plopesc committed 4ae04e8 on 7.x-2.x authored by idflood 
    Issue #2502205 by idflood: Facebook video new url
plopesc’s picture

plopesc
he/him
Primary language Spanish
CreditAttribution: plopesc as a volunteer commented
Status: Needs review » Fixed

Patch is working, thank you!
Already committed to -dev version, I'll release a new tag soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.