Hello,

Would it be good to have a search_api_attachments.schema.yml file in the module?

If yes, I will provide a patch :)

CommentFileSizeAuthor
#4 search_api_attachments-schema_files-2502073-3.patch1.92 KBGrimreaper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

izus’s picture

izus CreditAttribution: izus commented

why not, but is it normal that Core doesn't require it before installation ?

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented

Good question. Currently I don't know.

I was watching the code of the cas module, and I noticed that you had a such file in po_translation_report.

I think it is used only for Core when exporting or importing configuration.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Status: Active » Needs review

Hello,

Here is a patch that add the files.

Caution: I took the variable added in #2507751: Not using the conf value "search_api_attachments_java" java_path.

So in #2507751: Not using the conf value "search_api_attachments_java", the following line

'#default_value' => isset($this->configuration['java_path']) ? $this->configuration['java_path'] : 'java',

must be transformed into :

'#default_value' => $this->configuration['java_path'],

I read the documentation page about schema https://www.drupal.org/node/1905070, but I can't figure out how to take dynamically care of any additionnal plugins in other modules.

Thanks for the review.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
FileSize
search_api_attachments-schema_files-2502073-3.patch1.92 KB

Better with the patch. Sorry

  • izus committed c5960c2 on 8.x-1.x authored by Grimreaper 
    Issue #2502073 by Grimreaper, izus: schema.yml
izus’s picture

izus CreditAttribution: izus commented
Status: Needs review » Fixed

Thanks
this is now merged

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Status: Fixed » Needs review

Hello Izus,

There is a problem with the commit. The files were not created but the patch was added to the repository.

  • izus committed 5dacc6e on 8.x-1.x 
    Issue #2502073 by Grimreaper, izus: Fix adding schema.yml
izus’s picture

izus CreditAttribution: izus commented
Status: Needs review » Fixed

oh i see, that's because i needed some tea !
Thanks
this is now fixed

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented

:)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.