Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As shown in the image, I noticed this bug in the user login block where the two items inherited the wrong margin in the RTL version.
- Create new account
- Reset your password
The margin should be reset to 0
| Comment | File | Size | Author |
|---|---|---|---|
| #22 | Screen Shot 2015-09-11 at 15.51.34.png | 12.64 KB | emma.maria |
| #22 | Screen Shot 2015-09-11 at 15.51.39.png | 14.59 KB | emma.maria |
| #18 | D8-bartik-Fixed_RTL_item-list_margin-2501843-18.patch | 819 bytes | munzirtaha |
| #17 | core-bartik-Fixed_RTL_item-list_margin-2501843-17.patch | 825 bytes | munzirtaha |
| #16 | 2501843-classy_item-list.jpg | 41.67 KB | munzirtaha |
Comments
Comment #1
munzirtaha CreditAttribution: munzirtaha as a volunteer commentedComment #2
munzirtaha CreditAttribution: munzirtaha as a volunteer commentedComment #3
munzirtaha CreditAttribution: munzirtaha as a volunteer commentedComment #4
Manjit.SinghComment #5
Manjit.SinghThanks @munzirtaha for working on this.
I think this issue is in seven theme also. Please check before-item-list-class.png
So to correct the margin of
.item-listglobally, We have to overridesystem.theme.css. I have done the changes insystem.theme.cssPlease review at your end.Before
After
Comment #6
Manjit.Singhforget to attach patch file.
Comment #7
munzirtaha CreditAttribution: munzirtaha as a volunteer commentedThanks Manjit,
I checked your patch but there are many bugs regarding rtl bullets in drupal 8, mine is different than yours. The seven theme bullets in the LTR version and RTL version are already the same for the login block. Your patch made the RTL version different.
Comment #8
munzirtaha CreditAttribution: munzirtaha as a volunteer commentedI just created another issue at https://www.drupal.org/node/2501957 to discuss the solution
Comment #9
munzirtaha CreditAttribution: munzirtaha as a volunteer commentedComment #10
Manjit.Singhuploading the same patch there.. Please check that.
Comment #11
LewisNymanThis patch is for system CSS, so I'm moving this issue to the CSS component, can we get screenshots in Classy as well?
Comment #12
munzirtaha CreditAttribution: munzirtaha as a volunteer commented@LewisNyman: Thanks for pointing to test Classy as well. Now, I am pretty sure it's a bartik theme issue and not a system css bug. Attached is another patch tested with Bartik and Classy.
Comment #13
munzirtaha CreditAttribution: munzirtaha as a volunteer commentedComment #16
munzirtaha CreditAttribution: munzirtaha as a volunteer commented@LewisNyman: Updated the patch to specify margin-right specifically and here is how it looks in Classy after the patch
Comment #17
munzirtaha CreditAttribution: munzirtaha as a volunteer commentedSorry, something has gone wrong with the previous patch, here it's again
Comment #18
munzirtaha CreditAttribution: munzirtaha as a volunteer commentedseems I also need a margin-bottom: 0 so I reverted back to my old patch. Hopefully, this is the last mind change.
Comment #19
Manjit.Singh@munzirtaha Thanks for the patch. Now we just need a screenshots of Seven, Bartik and classy.
Comment #20
munzirtaha CreditAttribution: munzirtaha as a volunteer commented@Manjit.Singh: Thanks for your review but before taking this any further, I need your opinion on issue #2509902: Remove block.css list styles and add the code to other components. which if got accepted or a modified version of it, could render this patch obsolete, what do you think?
Comment #21
emma.maria@munzirtaha It's OK we can carry on with this issue. This is an easy win and I can see #2509902 requiring more thinking and patch iterations.
Comment #22
emma.mariaThis issue #2548805: Add sensible base layout styles for lists in Bartik. tidied up list styles and fixed a lot of problems in Bartik. Therefore the problem in this issue is no longer occurring.
