On the entity configuration page for invitation types, the Invite By E-mail module adds a "Use default settings" checkbox which is supposed to make the invitation type inherit the global settings at admin/config/people/invite/by_mail.

But this setting is ignored for the mail subject and body. Instead, the global settings are always used as the default when the subject and body are editable, and never used otherwise. This doesn't make sense.

Based on the #states code for the message that appears underneath the "Use default settings" checkbox, it looks like this checkbox was intended to control the mail body/subject too (which makes sense).

This patch fixes that, and also fixes the #states code so the help text corresponds to reality.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein’s picture

Status: Active » Needs review
FileSize
2.21 KB
ckng’s picture

Marking #2468283: Email token replacements broken because of outdated invite object as duplicate. Token issue will also need the following patch:
#2502263: Drupal 7.36 regression: hidden field textarea #default_value is ignored

Still reviewing this, initial test shows it is working for the mentioned context and solved the token issue. However seems to break something.

ckng’s picture

Status: Needs review » Reviewed & tested by the community

Tested patch #1 working correctly without side effect.

  • David_Rothstein authored 69c193b on 7.x-4.x
    Issue #2501427 by David_Rothstein, ckng: "Use default settings" option...
ckng’s picture

Status: Reviewed & tested by the community » Fixed

Committed.

Note that #2502263: Drupal 7.36 regression: hidden field textarea #default_value is ignored is still needed until that is resolved.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

cassio’s picture

This is fixed. One should remove it from the invite page and from the module description in the .info file.