I created GoPay gateway module similar to https://www.drupal.org/project/uc_gopay but this one works with Drupal Commerce. Module allows e-shop customers to pay via Czech GoPay payment gateway similar to PayPal. Module was originally developed for e-shop http://chefshop.cz and already works for couple of months in real life.

Project page: https://www.drupal.org/sandbox/vkuzel/2490192
Git clone: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/vkuzel/2490192.git

Thank you for promotion.

Comments

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxvkuzel2490192git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

ravi.khetri’s picture

ravi.khetri CreditAttribution: ravi.khetri commented

Hi,

1. Git errors:

It appears you are working in the "master" branch in git. You should really be working in a version specific branch.

2. Manual review :

A. Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
B. Undefined variable used in commerce_gopay_gw.notify.inc.
C. Class, function name must be prefixed with the project name.

rrfegade’s picture

rrfegade CreditAttribution: rrfegade commented

Hi,
1. Please correct your project clone link.
Please logout from drupal.org and check your project's version control tab for right link.

2. Please change the code errors mentioned in the below report:
http://pareview.sh/pareview/httpgitdrupalorgsandboxvkuzel2490192git

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commented

I have created new branch for the project 7.x-1.x and fixed clone link.

Also I fixed several problems (not all of them yet) described in the report. Specifically:

  • Removed LICENCE.txt file.
  • Removed trailing php end tags from several files.
  • Renamed some classes and keywords according to Drupal's coding standards.
  • Fixed several "uninitialised variable" php warnings.
  • Fixed some typos.

There are several things to do:

  • I am going to remove 3rd party library from module and let users to download it separately. Then I will load it by using libraries API as described in stack exchange library API article. I have two reasons for this: 1. library is not formatted according to Drupal's standards, 2. there is no GNU/GPL information included in the library. I was told by authors of it that it's GNU/GPL licensed and they will add license information into library but in 2 months they didn't do it.
  • Fix comments formatting.
  • Remove trailing spaces in code.
  • Fix long lines.
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer commented
Status: Closed (won't fix) » Needs review

I have fixed all known problems.

  • All 3rd party libraries has been removed from the module. Actually module uses new GoPay's REST API which doesn't need any 3rd party library.
  • All errors reported by http://pareview.sh has been fixed (I refactored major part of the module).
  • Added support for a payment refund.
  • Added unit test that tests creating of new payment.

Please check it out and feel free to comment on it.

denutkarsh’s picture

denutkarsh CreditAttribution: denutkarsh commented
Priority: Normal » Critical
sjpagan’s picture

sjpagan CreditAttribution: sjpagan commented

Fix the other errors: http://pareview.sh

FILE: ...repos/pareviewsh/pareview_temp/includes/commerce_gopay_gw.notify.inc
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
98 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
99 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
100 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
109 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
110 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
111 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/commerce_gopay_gw.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
sjpagan’s picture

sjpagan CreditAttribution: sjpagan commented
Status: Needs review » Needs work
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs work » Needs review

@sjpagan: Minor coding standards alone are surely not an application blocker. Anything else that you found or should this be RTBC instead?

gaurav_manerkar’s picture

gaurav_manerkar CreditAttribution: gaurav_manerkar commented

Please review this
https://pareview.sh/node/1101
Fix these errors first

gaurav_manerkar’s picture

gaurav_manerkar CreditAttribution: gaurav_manerkar commented
Status: Needs review » Needs work
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.