Hello,

I have found 2 bugs related to the page title translation
1. If you change the page title from the settings form or just save that form, so that the variable site_map_page_title gets set, the title of the page it doesn't get translated anymore.
2. If you haven't changed the title or haven't saved the settings form and you access the settings form from a different language, the page title in the form will be shown translated and you might overwrite the page title with its translation.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dragos-dumi’s picture

I attached a patch for this issues.

dragos-dumi’s picture

Status: Active » Needs review

  • colan committed 0ad2752 on 7.x-1.x
    Issue #2500421 by colan: Make the built-in page title translatable until...
colan’s picture

Version: 7.x-1.2 » 7.x-1.x-dev
Status: Needs review » Needs work

Thanks for the patch, but t() shouldn't be used to translate variables. See that manual page or Translating user-entered strings in D7 for more information.

For now, I've set it up so that the built-in "Site map" string is translatable, but not if you actually set anything on the configuration screen. As soon as that happens, that title will take over for all languages. This is less than optimal, but it's the best we can do until we get a proper i18n_string() implementation.

If you could provide a patch for that, I'd really appreciate it!

colan’s picture

Title: Page title translation » Make custom page titles translatable
Category: Bug report » Feature request

  • colan committed 16f54fb on 7.x-1.x
    Issue #2500421 by colan: Don't use configured page title if it's empty.
    

  • colan committed ec4bca7 on 7.x-1.x
    Issue #2500421 by colan: Added more help text for translating the page...