The YPlan modules provides a block to display affiliate ads from https://yplanapp.com

Sandbox URL
https://www.drupal.org/sandbox/malcomio/2499271

GIT Clone URL
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/malcomio/2499271.git yplan

Comments

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Pravin Ajaaz’s picture

Issue summary: View changes

Added clone URL

darol100’s picture

Status: Needs review » Reviewed & tested by the community

@malcomio,

Thank you for your contribution.

Automated Review

Pareview.sh is showing some complains in your README.txt - http://pareview.sh/pareview/httpgitdrupalorgsandboxmarkfullmer2492455git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows guidelines for project length and complexity.

This project is too short.

Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. You should add the configuration page in your .info file, which in this case is this admin/config/services/yplan.
  2. All your fields are textfield, I think these fields yplan_items and yplan_width should only accept numbers, because that is what it suppose to be enter right ?
  3. I would strong recommend to remove all your variable once you module is been unistall.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I do not see any blockers.

malcomio’s picture

Thanks @darol100 - good suggestions, and they should all be fixed now.

By the way I think you've pasted the wrong PAreview URL - the right one is http://pareview.sh/pareview/httpgitdrupalorgsandboxmalcomio2499271git

The only issues found on that automated review are lines being too long in the README, which seems to be pretty common among contributed modules.

cweagans’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

malcomio’s picture

Thanks for your help, everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.