The edit functionality in the WYSIWYG plugin has some strange behaviors, particularly without Media WYSIWYG View Mode enabled. I don't think the functionality is necessary for Media to support, and the plugin would be much more straightforward if it were simply removed, so the attached patch does that.

CommentFileSizeAuthor
#4 2497453_04.patch1.6 KBcweagans
#3 2497453_03.patch1.51 KBcweagans
#1 2497453_01.patch1.46 KBcweagans
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
CreditAttribution: cweagans at NBCUniversal commented
FileSize
2497453_01.patch1.46 KB
Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Active » Needs review
cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
CreditAttribution: cweagans at NBCUniversal commented
FileSize
2497453_03.patch1.51 KB

Got a little excited when I was deleting code and took out a line I shouldn't have.

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
CreditAttribution: cweagans at NBCUniversal commented
FileSize
2497453_04.patch1.6 KB

Adding @return on isNode() method.

Elijah Lynn’s picture

Elijah Lynn
Location Portland, Oregon
CreditAttribution: Elijah Lynn at NBCUniversal commented
Status: Needs review » Needs work 
+++ b/modules/media_wysiwyg/js/wysiwyg-media.js
@@ -16,11 +16,19 @@ Drupal.wysiwyg.plugins.media = {
+   * @return boolean
+   *   Whether or not this plugin "owns" the supplied DOM element.
    */
   isNode: function(node) {
-    return $(node).is('img[data-media-element]');
+    return false;

Technically it is @return bool. But I think in this case it is actually just @return false since it doesn't ever return true.

https://www.drupal.org/coding-standards/docs#types

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Status: Needs work » Closed (outdated)

Closing this issue as outdated. However, if you think this issue is still important, please let us know and we will gladly re-open it for review.
sincerely,
- the Drupal Media Team