I've started using Zen 5.5 a few days ago. While modifying my subtheme responsive.scss I see the following things that confuse me (line numbers refer to the original starter kit numbers). Could you explain them to me or are they perhaps typoes that should be fixed?

On line 24 of _responsive.scss

// Suppress this section of CSS for RTL layouts since it contains no LTR-specific styles.
@if $zen-reverse-all-floats == false {

Why is this suppressed for RTL layouts if it has no LTR/RTL specific styles. If it's non-direction specific it should probably be included in the RTL styles so the if statement makes no sense. Otherwise the wording should say they do contain LTR specific styles (which afaik isn't the case).

Then on line 74 the following code closes the if statement:
} // End of @if $zen-reverse-all-floats == true

This suggests either the condition in the opening if statement is incorrect which would disable something that shouldn' t be disabled. Or this closing statement should be commented with == false.

As far as my understanding goes this breaks the RTL layout? It doesn't seem to pull the navigation up.

Comments

JohnAlbin’s picture

Status: Active » Fixed

Or this closing statement should be commented with == false.

That's correct.

I've changed the top comment to:

// Suppress this section of CSS for RTL layouts since it contains no CSS that
// needs RTL-specific overrides.

Hopefully this will make its purpose more clear.

  • JohnAlbin committed 0884629 on 7.x-5.x
    Issue #2497005: Make $zen-reverse-all-floats comment easier to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.