Because the SimpleTest tests do not use the Discogs.com OAuth key/secret, many of the tests fail. This should be fixed so that TDD can continue.

CommentFileSizeAuthor
#4 0001-Issue-2496799-by-Karlheinz-Modify-tests-to-use-Disco.patch1.2 KBKarlheinz
#2 Issue-2496799-by-Karlheinz-Modify-tests-to-use-Disco.patch4.44 KBKarlheinz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

  • Karlheinz committed a4ea94d on 7.x-1.x 
    Issue #2496799 by Karlheinz: Modify tests to use Discogs.com key/secret
Karlheinz’s picture

Karlheinz CreditAttribution: Karlheinz commented
Status: Active » Fixed
FileSize
Issue-2496799-by-Karlheinz-Modify-tests-to-use-Disco.patch4.44 KB

Fixed, pushed, and patch included. I will keep this issue open for a little while in case more of the tests need to be modified.

  • Karlheinz committed 22cce30 on 7.x-1.x 
    Issue #2496799 by Karlheinz: Modify tests to use Discogs.com key/secret
Karlheinz’s picture

Karlheinz CreditAttribution: Karlheinz commented
FileSize
0001-Issue-2496799-by-Karlheinz-Modify-tests-to-use-Disco.patch1.2 KB

Spoke too soon... I put the keys into a file called discogs_prov.test.inc, so that they weren't hard-coded into the test itself. This file will not be added to the repo. Anyone else who wants to use the tests (which, who am I kidding, is nobody) will need to create one of their own.

This is the contents of that file (with keys redacted):

define('DISCOGS_PROV_KEY', '[redacted]');
define('DISCOGS_PROV_SECRET', '[redacted]');

Patch is also attached.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.