We have our CNAME in the same domain as our main site. We also are unable to use any kind of "proxy-passing" for the css/js urls. We would like the re-writing of the aggregated css/js files to be optional so that we can implement our own solution on how to handle that.

This patch makes it optional.

HOW TO TEST

  1. Use this patch on s2fs 2.0
  2. Go to admin/config/media/s3fs, and enable public and private file handling by S3.
  3. Verify that your CSS JS files are NOT prefixed by s3fs-css or s3fs-js
  4. Go to admin/config/media/s3fs and check "Rewrite CSS/JS urls", save.
  5. Verify that the CSS/JS urls are now prefixed.
CommentFileSizeAuthor
#4 2496517-s3fs-jss-rewrite-optional.patch3.75 KBSouvent22
#3 2496517-s3fs-jss-rewrite-optional.patch3.65 KBSouvent22
#2 2496517-s3fs-jss-rewrite-optional.patch5.45 KBSouvent22
#1 2496517-s3fs-jss-rewrite-optional.patch6.5 KBSouvent22
s3fs-jss-rewrite-optional.patch6.5 KBSouvent22

Comments

Souvent22’s picture

Souvent22 commented
StatusFileSize
new 2496517-s3fs-jss-rewrite-optional.patch6.5 KB
Souvent22’s picture

Souvent22 commented
StatusFileSize
new 2496517-s3fs-jss-rewrite-optional.patch5.45 KB

Removing the white space cleanup.

Souvent22’s picture

Souvent22 commented
StatusFileSize
new 2496517-s3fs-jss-rewrite-optional.patch3.65 KB

Less line ending cleanup.

Souvent22’s picture

Souvent22 commented
StatusFileSize
new 2496517-s3fs-jss-rewrite-optional.patch3.75 KB

Latest patch keeps the current functionality as the default.

coredumperror’s picture

coredumperror commented
Status: Active » Fixed

Huh, I wasn't aware that it was possible to set up a site in such a way as to make the s3 bucket and the site itself on the same domain.

This seems like a functional and useful feature (and thanks for making the existing default stay the same in your later patch, as I would have had to do that myself), so I'll go ahead and add it.

  • coredumperror committed 15998a4 on 7.x-2.x 
    Issue #2496517: Added option to not rewrite css/js file paths during...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.