[D7] Pipedrive

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsmonetti2496101git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Steven,

I think. you should add to your title [D7]: "Pipedrive" => [D7] Pipedrive.
Or whatever Drupal version you are targeting this one.

Drupal 6/7/8 are quite different animals + normally not compatible with the same code of module.

This helps any reviewer to pick up your offer better, also.

BR,
Jouni

Hi there,
Thank you for your contribution! Module code looks clean with the pareview.sh with the latest code. I went ahead and did a manual test as well.

- Modules needs to remove all variables created by it when uninstalling. This module adds pipedrive_api_token, which needs to be removed in a hook_uninstall hook.

- In pipedrive.admin.inc file, you do not really have to add a submit handler to the form if you use system_settings_form. Saving the variable and showing a success message is exactly what system_settings_form function-added submit handler is doing anyway.

- I tried to load the library using pipedrive_load_library() as mentioned in the README file, but could not get libraries module to integrate it correctly. pipedrive_load_library() function triggers a fatal error. Please double check it as well.

Thanks Steven.
I will take another look tomorrow. My test site was probably broken anyway, so I'll start with a new one.

Feel free to set the status to "Needs review" so others can review this too.

Automated Review

Pareview.sh - No errors: http://pareview.sh/pareview/httpgitdrupalorgsandboxsmonetti2496101git

Coder

No Errors

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows guidelines for project length and complexity.

This project is too short.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. You should add the hook_help,

this would help site builder to get information about your module insider of the Drupal UI.

2. Something that it would be nice is to have an integration with drush to download the library for you with a command. Some modules like colorbox and mobile_detect have a the ability of downloading/extract/rename with a drush command.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I do not see any blockers. I can confirm that the library is been recognized.

@Steven Monetti, Now you have to wait until an administrator revise your project. If you want to speed up this process you can review 3 project and add the PAReview: review bonus tag. If you want to learn more about the Review bonus click here.

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.