In PHP 5.4, I receive the following error message when visiting the Content Analysis reports page:

Strict warning: Only variables should be passed by reference in contentanalysis_page_analyzer() (line 177 of /sites/all/modules/contentanalysis/contentanalysis.module).

This is due to how the render call is constructed in the contentanalysis_page_analyzer function. I'll post a patch for review in a minute.

CommentFileSizeAuthor
#1 contentanalysis-render_by_reference-2496125-1.patch582 bytesron_s
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ron_s’s picture

ron_s CreditAttribution: ron_s commented
Status: Active » Needs review
FileSize
contentanalysis-render_by_reference-2496125-1.patch582 bytes

Patch is attached for review. Thanks.

ron_s’s picture

ron_s CreditAttribution: ron_s commented
Issue summary: View changes
ron_s’s picture

ron_s CreditAttribution: ron_s commented

Ok, there's something very odd going on. Used the 7.x-1.x branch to create that patch, but it does not apply cleanly. It looks like the module has maybe some extra carriage returns that are causing an issue? If I try to delete the lines and replace them, it doesn't even reference the patch in the right location!

If one of the module owners can help in getting this corrected I'd appreciate it, thanks.

  • kyletaylored committed 58e96f0 on 7.x-1.x authored by ron_s 
    Issue #2496125 by ron_s: Only variables should be passed by reference in...
kyletaylored’s picture

kyletaylored CreditAttribution: kyletaylored at LevelTen Interactive commented
Status: Needs review » Fixed

It looks like this was fixed at some point in time, so I'll close this out. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.