Rename xmlhttprequest to jqXHR in Drupal Ajax JS

This patch seem good to me.

Fixing the issue tag.

Needs a reroll due to #2279105: Remove as many "..." and ellipsis characters from the codebase as possible without altering the meaning of text.

I would work on this tonight.

Here is the patch.

The console.log needs to be removed and the JSDocs updated to match the new parameter name

core/misc/ajax.js
   391:8   error    Unexpected console statement                                 no-console
   391:26  error    Missing semicolon                                            semi
   618:2   warning  Expected JSDoc for 'jqXHR' but found 'xmlhttprequest'        valid-jsdoc

Do we need to updated the parameter on line 94 and 95 ?

Uploaded a fresh patch, please review!

@tameeshb,

Changes are good to go with. Changing to RTBC.

+++ b/core/misc/ajax.js
@@ -110,8 +110,8 @@
-   * @param {XMLHttpRequest} xmlhttp
-   *   XMLHttpRequest object used for the failed request.
+   * @param {jqXHR} xmlhttp
+   *   jqXHR object used for the failed request.

How come we're not renaming the variable here? We do elsewhere in the patch. @droplet / @nod_ shall we rename all the variables?

+++ b/core/misc/ajax.js
@@ -745,12 +745,12 @@
+   * @param {jqXHR} jqXHR
    *   Native Ajax object.

@@ -938,14 +938,14 @@
+   * @param {object} jqXHR
+   *   Native jqXHR object.

I don't think the jquery UI is a native object. To me native object means something that exists a core feature of the javascript language. The point of this change is to document we're not using the native object :)

As a task this is only eligible for 8.4.x - you could argue that fixing the typehints and documentation is a bug. If we want to get this in 8.3.x then we need to separate up the bits that address the buggy documentation and task which is renaming variables to something better.

Hi,

I just changed the 'Native' and variable name.

Adding tag.

Changed wrong line 424.

Removed Needs Reroll tag.

Updated for version 8.6.x

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

patch for 10.1.x

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Fix for failures in #39
Thanks

Removing credit from #39 and #41 as it is expected to check your patch before uploading.

The last patch doesn't pass commit checks, could you make sure to run ./core/scripts/dev/commit-code-check.sh before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel...

This seems like it needs an issue summary update.

Reuploading patch after code formatting.

Re-uploading patch.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Rerolled patch #44, please review it.

Thanks!

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

trying to fix ccf in #39 & #41 by using
./core/scripts/dev/commit-code-check.sh
as suggested in #42

reroll for 10.1.x
please review it

Still tagged for issue summary update