Follow-up to #2494989: Don't render main help pages on modules page just to generate help links - can lead to high memory usage on form submit

Problem/Motivation

#2494989: Don't render main help pages on modules page just to generate help links - can lead to high memory usage on form submit removes the call for field_hook, though we have the issue of calling all module's field/widget/formatter, just to render help content.

Proposed resolution

Remove the list of modules from field_help() and place it as separate page and link it from help content.

Remaining tasks

User interface changes

No list of field type/widget/formatter-providing modules on the field help page. Will be listed in separate page.

API changes

CommentFileSizeAuthor
#20 2495363-20.patch7.43 KBranjith_kumar_k_u
#19 2495363-19.patch8.51 KBkarishmaamin
#17 2495363-17.patch7.62 KBkarishmaamin
#4 2495363-diff-1-4.txt881 bytesvijaycs85
#4 2495363-4.patch7.62 KBvijaycs85
#1 2495363-field-module-help-1.patch6.76 KBvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer commented
Status: Reviewed & tested by the community » Needs review
FileSize
2495363-field-module-help-1.patch6.76 KB

Initial patch...

Status: Needs review » Needs work

The last submitted patch, 1: 2495363-field-module-help-1.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

Just a note that with a warm cache this listing isn't great, but it's probably OK given that it's a rarely visited page.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer commented
Status: Needs work » Needs review
FileSize
2495363-4.patch7.62 KB
2495363-diff-1-4.txt881 bytes

Fixing test fails.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Priority: Major » Normal

Bumping down to normal since the parent is fixed.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Category: Bug report » Task
Issue tags: +Bug Smash Initiative, +Novice, +Needs reroll

Moving to a task and adding tags

karishmaamin’s picture

karishmaamin CreditAttribution: karishmaamin at Specbee commented
Version: 9.3.x-dev » 9.4.x-dev
FileSize
2495363-17.patch7.62 KB

Re-rolled against 9.4.x

Shashwat Purav’s picture

Shashwat Purav CreditAttribution: Shashwat Purav at Portage CyberTech for Drupal Association commented
Status: Needs review » Needs work

@karishmaamin, patch failed to apply successfully to 9.4.x branch.

karishmaamin’s picture

karishmaamin CreditAttribution: karishmaamin at Specbee commented
Status: Needs work » Needs review
FileSize
2495363-19.patch8.51 KB

Fixed custom code failure

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u CreditAttribution: ranjith_kumar_k_u at Zyxware Technologies commented
FileSize
2495363-20.patch7.43 KB

Re-rolled for 9.4

Status: Needs review » Needs work

The last submitted patch, 20: 2495363-20.patch, failed testing. View results

p.ayekumi’s picture

p.ayekumi
Primary language English
Location Chicago
CreditAttribution: p.ayekumi as a volunteer and at Palantir.net commented
Issue tags: -Needs reroll +Portland2022

Looked over this issue as part as DrupalCon Portland 2022. Noticed that the patch has already been rerolled. Removing the tag

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.