This issue deals with #2494695: [meta] Deprecate dependency setters and getters on interfaces for \Drupal\Core\language\LanguageManagerInterface.

CommentFileSizeAuthor
#4 drupal_2494705_4.patch616 bytesXano
#1 drupal_2494705_1.patch614 bytesXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Title: Deprecate dependency setters and getters on LangaugeManagerInterface » Deprecate dependency setters and getters on LanguageManagerInterface
Status: Active » Needs review
FileSize
drupal_2494705_1.patch614 bytes
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Parent issue: » #2494695: [meta] Deprecate dependency setters and getters on interfaces
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

I think the 2nd line should be indented, the way we do for @throws and other tags?

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
drupal_2494705_4.patch616 bytes

Yup, thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Component: documentation » language system

Thanks! Tthe formatting looks good to me now.

But I cannot comment on whether the methods should be deprecated, so I think I'll leave the RTBC to someone else... and this is probably not really just Documentation: deprecating a function is not really a docs issue.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Closed (won't fix)

It looks like Drupal\Core\Language\TranslationManagerInterface no longer has a setTranslation() method.