Sorry if the qualifies for minor nit pick of the week... it is as least quick to review :)

I'm not sure what the @abstract is trying to denote here, and I find it slightly distracting...

There are no @abstract tag in core.. for comparison.

I might be persuaded that abstract is correct, but not necessarily a useful contribution to an interface class as a whole.

but it makes no sense to label an individual method on a interface as abstract!

On a super nit picky note the coding standard demands @param be the first tag in a method comment block... so it is also showing up in a phpcs check of the file.

CommentFileSizeAuthor
abstract-0.patch489 bytesmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107’s picture

martin107 CreditAttribution: martin107 commented

From
http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutoria...

The @abstract tag is only valid in PHP 4, PHP 5 has a keyword abstract.

This should definitely go....

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

If it's not used in core, then it's almost certainly not recognized by API module. So indeed, there's no point having it. I think we can go with this without waiting for the tesbot...

Thanks! Clean-ups always appreciated, no matter how nitpicky :)

  • joachim committed 9c7b662 on 8.x-4.x authored by martin107 
    Issue #2493471 by martin107: Removed @abstract tag from...

Status: Fixed » Needs work

The last submitted patch, abstract-0.patch, failed testing.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.