There are two empty elements between shortcut and admin.

CommentFileSizeAuthor
#28 admin_toolbar_issue.png27.08 KBmimran
#21 admin_toolbar-empty-elements-in-toolbar-2493037-21-8.x.patch747 bytesmimran
#10 empty_elements_in-2493037-10.patch719 bytesAnonymous (not verified)
#4 empty_elements_in-2493037-4.patch814 bytesAnonymous (not verified)
#1 admin_toolbar_empty_tabs.jpg165.5 KBdrupov
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drupov’s picture

drupov CreditAttribution: drupov commented
FileSize
admin_toolbar_empty_tabs.jpg165.5 KB

Just a screenshot showing this.

And btw, really great module, thanks!

drupov’s picture

drupov CreditAttribution: drupov commented
Title: Empty elements in the black part » Empty elements in #toolbar-bar
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at FFW commented
Assigned: Unassigned »
Status: Active » Needs work

I find the origin of this issue.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at FFW commented
Assigned: » Unassigned
Status: Needs work » Needs review
FileSize
empty_elements_in-2493037-4.patch814 bytes

The trouble was that stylesheet was attached to empty toolbar item, I've moved it to another item. Please review.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at FFW commented
Version: 8.x-1.4 » 8.x-1.x-dev

  • matio89 committed 5e9e72e on 8.x-1.x authored by bobrov1989 
    Issue #2493037 by bobrov1989: Empty elements in #toolbar-bar
matio89’s picture

matio89 CreditAttribution: matio89 commented
Status: Needs review » Fixed
cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
CreditAttribution: cweagans at NBCUniversal commented
Status: Fixed » Needs work

This is still an issue if the admin_toolbar_tools module is enabled.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at FFW commented
Assigned: Unassigned »
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at FFW commented
Assigned: » Unassigned
Status: Needs work » Needs review
FileSize
empty_elements_in-2493037-10.patch719 bytes

I've fixed it. Please review.

drupov’s picture

drupov CreditAttribution: drupov commented

I had the bug with version 1.4.

If I try to update to 1.6 or latest dev I get an error:

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "toolbar.menu_tree". in Symfony\Component\DependencyInjection\Container->get() (line 317 of core/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Container.php).

eme’s picture

eme CreditAttribution: eme at emerya commented

Please provide us with the version of Drupal Core. And please post in another post if it is not directly related to this one (which seems to be the case).

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at FFW commented

It is not related to this issue because my patch haven't been commited to dev branch.

eme’s picture

eme CreditAttribution: eme at emerya commented

Then please open a new issue with all the data (core version, etc.). Thanks.

eme’s picture

eme CreditAttribution: eme at emerya commented
Status: Needs review » Active

Seems this bug is back again.

VBN’s picture

VBN CreditAttribution: VBN as a volunteer commented

Yes indeed, same here with 8.0.1 core.

Also the logo on the left side is gone (id toolbar_link_front)

eme’s picture

eme CreditAttribution: eme at emerya commented

I do not see a bug on the logo. Have you properly installed admin toolbar tools ?

VBN’s picture

VBN CreditAttribution: VBN as a volunteer commented

Cron did the job, picture is back.

But there is still that empty space thing.

mimran’s picture

mimran CreditAttribution: mimran commented
Status: Active » Needs review

Checked the following patch with 8.0.2 working fine
https://www.drupal.org/files/issues/admin_toolbar-empty-elements-in-tool...

The last submitted patch, 4: empty_elements_in-2493037-4.patch, failed testing.

mimran’s picture

mimran CreditAttribution: mimran commented
FileSize
admin_toolbar-empty-elements-in-toolbar-2493037-21-8.x.patch747 bytes

Updated the patch

SajithAthukorala’s picture

SajithAthukorala CreditAttribution: SajithAthukorala commented
Status: Needs review » Reviewed & tested by the community

Checked with drupal version "drupal-8.0.2" and works fine for me.
patch : #21 admin_toolbar-empty-elements-in-toolbar-2493037-21-8.x.patch

mimran’s picture

mimran CreditAttribution: mimran commented

Thanks for testing this @SajithAthukorala

  • matio89 committed 9f0fa87 on 8.x-1.x authored by mimran 
    Issue #2493037 by mimran: Empty elements in #toolbar-bar
mimran’s picture

mimran CreditAttribution: mimran commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Macronomicus’s picture

Macronomicus CreditAttribution: Macronomicus commented
Status: Closed (fixed) » Needs review

had to run the patch in #21 again on the latest release to resolve the empty item again, you sure this was added in and didn't get lost in the shuffle?

mimran’s picture

mimran CreditAttribution: mimran commented
FileSize
admin_toolbar_issue.png27.08 KB

@Macronomicus checked with 8.0.3(drupal) and 8.x-1.14 (admin toolbar )issue was still there attached the screenshot as well some how we missed the patch

  • eme committed f0a5925 on 8.x-1.x 
    fix Issue #2493037
eme’s picture

eme CreditAttribution: eme at emerya commented
Status: Needs review » Fixed

Indeed. Patch has been lost. Commited again and seem to work fine.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Bcwald’s picture

Bcwald CreditAttribution: Bcwald commented

I am still seeing this issue on 8.1x with latest dev build. anyone else still have this problem?