Problem/Motivation

When the module is enabled but no hard or soft limits have been defined, systems using the message_notify module will experience subscription removals for users whose email addresses are present in the bounce_statistics table.

CommentFileSizeAuthor
#1 bounce_handler-2492467-1.patch3.19 KBbdurbin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bdurbin’s picture

bdurbin CreditAttribution: bdurbin commented
Status: Active » Needs review
FileSize
bounce_handler-2492467-1.patch3.19 KB

It looks as if the conditions count check is always returning TRUE due to the $query->conditions() call return value looking like what's below, regardless of whether or not any of the specific limit-related clauses have been added:

Array
(
    [#conjunction] => AND
)

A draft patch is attached. If it's desired that the table cleanup at the bottom of the hook_cron() implementation still occurs even in the case where neither limit is configured, I'd suggest we break out cleanup and unsubscribe logic into separate child functions, which I'd be happy to do in an updated patch.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Status: Needs review » Fixed

a rather unfortunate oversight...

I've reviewed but not tested the patch and pushed it to git.

I will roll a beta2 release.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.