MathJax CDN option text does not make sense

You must check the CDN box, even if you are using your own copy of the library. The wording is poor in that dialog. To not check the box means "use the library from the default libraries location".

There is the answer. This is something to fix in terms of the wording.

I've bumped this to 8.x-2.x because it looks the same there too.

I would redesign this with radio buttons with this approximate wording:

• Use the default CDN
• Use your URL (if chosen, a text box appears)
• Use the library location (if chosen, a note appears explaining what to do)

I'd be happy to create a patch for this based on @cilefen comment #3. Will have something within in a week if that is OK.

Patch submitted for review

@hameerabbasi Thank you for testing this.

Usually, use git apply. In this case, you should be in the module directory. Note, the patch is for Drupal 8 and you must patch against a git checkout of this project. In Drupal 8, that will be in modules/mathjax.
https://www.drupal.org/node/1054616

@hameerabbasi I am pleased to have you helping. We will need continued help so I would like to show you how this is done. There are some things you may not know that will help things make sense:

1. Downloading and installing modules via the GUI in Drupal 8 is broken right now, which is why it did not work for you.
2. Patches are always "rolled" against the development branch. That means you must have git installed to test a patch.

One of the *amp stacks may provide you a command prompt with access to git or download it. Next, do the following:

cd modules
git clone --branch 8.x-2.x http://git.drupal.org/project/mathjax.git

It will be a good idea to get the libraries module as well and unzip it to modules/libraries.

Now you can return to the Drupal 8 GUI and enable the MathJax module. You should verify that the module works before applying the patch. Next, you apply the patch:

cd modules/mathjax
git apply ClarifyMathJaxOptionText.patch

Clear the site caches and review the changes.

@hameerabbasi,

This patch should address the issue you mentioned in comment #13.

A new variable/constant is created for the official MathJax CDN so that it does not depend on the value of the textfield.

Just type this command assuming we left off where we did:

git apply interdiff.txt

The txt file will need to be added to the MathJax 8 directory. You will also need to be in that directory when you execute the command. You may get a warning about whitespace but it can be ignored at this point.

Since we already applied the first patch, you don't need to worry about ClarifyMathJaxOptionText2.patch attached to this comment.

@hameerabbasi Thank you for reviewing. I have a few more things to add:

+++ b/src/Form/MathjaxSettingsForm.php
@@ -45,20 +45,25 @@ class MathjaxSettingsForm extends ConfigFormBase {
+      '#title' => $this->t('Path to MathJax source files'),

Would "Path to MathJax source" make more sense here?

Custom URL could be path could be "Custom URL".

If "MathJax CDN" is chosen, the text input field should be visible but disabled.

Let's start with those.

Attaching patch with recommendations from comment #18.

Let's not rush.

After retesting, patch in comment #19 still works well.

'"Custom URL" source' should be 'Custom URL'.

When you switch from 'MathJax' CDN to 'Custom URL' and back to 'MathJax CDN', the module does not render equations any more.

There could be other issues but let's start with those.

The equations are still being rendered when I switch between CDN and Custom the way you mention.