As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.
Here is the summary of running ESLint on this module JS:
✖ 1056 problems (1056 errors, 0 warnings)

Attached is the full list of errors found by ESLint. A lot of it has to do with indentation and brackets around ifs. I am not sure which files are third party or not so here is the report for all of them, feel free to ignore report on third party files.

CommentFileSizeAuthor
#1 imce-ESLint-reformat-2491233-patch.diff219.77 KBVSKor
imce-eslint-output.txt132.41 KBnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

VSKor’s picture

VSKor CreditAttribution: VSKor commented
FileSize
imce-ESLint-reformat-2491233-patch.diff219.77 KB

Hi,
Here is patch with reformatted code.

VSKor’s picture

VSKor CreditAttribution: VSKor commented
Status: Active » Needs review

  • ufku committed 971e4c7 on 8.x-1.x 
    Issue #2491233 by nod_, VSKor: IMCE ESLint errors
ufku’s picture

ufku CreditAttribution: ufku commented
Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.