Add an external class on all external links like the old theme does.
Also add a title attribute suffix for accessibility purposes.

CommentFileSizeAuthor
#6 add_an_class_on-2491205-6.patch1.28 KBOostie
#4 add_an_class_on-2491205-4.patch1.28 KBOostie
#1 add_an_class_on-2491205-1.patch1.31 KBOostie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Oostie’s picture

Oostie
Primary language Dutch
Location Kampen
CreditAttribution: Oostie as a volunteer commented
FileSize
add_an_class_on-2491205-1.patch1.31 KB

Attached patch adds the theme_link function as it is in the old rijkshuisstijl theme.
This patch also adds an suffix on the title attributes or a new title when the link is external.

Oostie’s picture

Oostie
Primary language Dutch
Location Kampen
CreditAttribution: Oostie as a volunteer commented
Status: Active » Needs review
BarisW’s picture

BarisW CreditAttribution: BarisW at LimoenGroen commented 
+++ b/template.php
@@ -171,3 +171,33 @@ function rijkshuisstijl_breadcrumb(&$variables) {
+      $title = t('@title', array('@title' => $title));

This is not correct. Can this be changed to t('@title (Opens an external page)')?

Oostie’s picture

Oostie
Primary language Dutch
Location Kampen
CreditAttribution: Oostie as a volunteer commented
FileSize
add_an_class_on-2491205-4.patch1.28 KB

This one should be better.

BarisW’s picture

BarisW CreditAttribution: BarisW at LimoenGroen commented 
+++ b/template.php
@@ -171,3 +171,32 @@ function rijkshuisstijl_breadcrumb(&$variables) {
+    if (isset($variables['options']['attributes']['title'])) {

One minor thing: please change isset to !empty, so that this also works if a title is set but empty.

Otherwise: great addition!

Oostie’s picture

Oostie
Primary language Dutch
Location Kampen
CreditAttribution: Oostie as a volunteer commented
FileSize
add_an_class_on-2491205-6.patch1.28 KB

Thanks for the quick reaction!

BarisW’s picture

BarisW CreditAttribution: BarisW at LimoenGroen commented
Status: Needs review » Reviewed & tested by the community
BarisW’s picture

BarisW CreditAttribution: BarisW at LimoenGroen commented
Issue tags: +rijkshuisstijlsprint

To be committed today

BarisW’s picture

BarisW CreditAttribution: BarisW at LimoenGroen commented
Status: Reviewed & tested by the community » Fixed

Thanks, works great.

  • BarisW committed 7a7f7f3 on 7.x-3.x authored by Oostie 
    Issue #2491205 by Oostie, BarisW: Add an class on external links

  • Martijn de Wit committed e4766e3 on 7.x-3.x 
    Merge branch '7.x-3.x' of git.drupal.org:project/rijkshuisstijl into 7.x...

  • BarisW committed 4fd7c7d on 7.x-3.x authored by Oostie 
    Issue #2491205 by Oostie, BarisW: Add an class on external links
  • Martijn de Wit committed 51ab3e9 on 7.x-3.x
    Merge branch '7.x-3.x' of git.drupal.org:project/rijkshuisstijl into 7.x...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.