hook_uc_checkout_complete being called before hook_uc_order ($op='submit') [#2490446]

I have a module which needs to capture the account creation done by ubercart. In prior versions (3.5) hook_uc_order with $op = 'submit' was called prior to hook_uc_checkout_complete. In version 3.8, at least, this order is inverted. In version 3.5, this was not the case.

Comments

Comment #1

richardl@ufp.com CreditAttribution: richardl@ufp.com commented 18 May 2015 at 13:44

Issue summary:

View changes

Comment #2

richardl@ufp.com CreditAttribution: richardl@ufp.com commented 19 May 2015 at 17:10

In looking further, this is not a problem with the version of Ubercart. This problem is dependent on the payment configuration. A number of the payment modules call uc_cart_complete_sale() internally, circumventing the normal flow of the checkout. Specifically

grep -R complete_sale payment/*
payment/uc_2checkout/uc_2checkout.pages.inc:  $build = uc_cart_complete_sale($order, variable_get('uc_new_customer_login', FALSE));
payment/uc_cybersource/uc_cybersource.module:      uc_cart_complete_sale($order);
payment/uc_google_checkout/uc_google_checkout.module:    uc_cart_complete_sale($order);
payment/uc_payment/uc_payment.module:    uc_cart_complete_sale($order);
payment/uc_paypal/uc_paypal.pages.inc:        uc_cart_complete_sale($order);