Now that #1890906: Information disclosure: Project* is not properly allowing node_access to work on listing queries in D7 is fixed, I started looking into the equivalent bugs for project_issue, and it looks like we are indeed missing some node_access tags in various queries. I'm working on it now. Stay tuned for patch and/or commits. The good news is it appears we're only potentially leaking project titles, not issue node titles. At least in the case of sec.d.o, leaking project titles isn't really an info disclosure bug. So, I feel okay dealing with this here in the open.

CommentFileSizeAuthor
#1 2490022-1.project-issue-node-access.patch6.96 KBdww
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww’s picture

dww’s picture

Status: Active » Needs review

  • dww committed e1250e6 on 7.x-2.x
    [#2490022] Properly enforce node_access on list queries.
    
dww’s picture

Status: Needs review » Fixed

drumm looked this over at the sprint. He said "looks good", so I pushed the commit. If something breaks, we'll find out. ;)

Status: Fixed » Needs work

The last submitted patch, 1: 2490022-1.project-issue-node-access.patch, failed testing.

dww’s picture

Status: Needs work » Fixed

Hah, by the time the bot ran this, I had already pushed the fix. ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alexandrezia’s picture

This fix has introduced a bug on login, please see this issue: https://www.drupal.org/node/2559613

alexandrezia’s picture

drumm’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.