Combine fields filter does not search fields excluded form display [#2489818]

Summary

If a field is excluded from display, but is included in the Combine fields filter, it does not actually get filtered. Various issues may come about, see Related issues.

Steps to reproduce

Create a content type with a Text field
Create a view displaying fields of that content type
Add two fields (e.g. title & text field)
Exclude text field from display
Create Combine fields filter
Expose the filter, Set it as Required
Include both fields to be searched on
Search for a value that is only in the excluded text field
See that the record isn't filtered

Related issues

In 7.x-3.11, the issue that arises is #2284593: Fatal error: Call to a member function ensure_my_table() on a non-object , which simply prevents $field->ensure_table() on non-objects.
In 7.x-3.x-dev the issue is simply that Combine fields filter does not actually search the excluded fields.
When testing from a Drush qd I get "SQLSTATE[HY000]: General error: 1 no such function: CONCAT_WS" because CONCAT_WS is not supported by SQLite. See #2009238: CONCAT_WS is not compatible with all database drivers and #2318191: [meta] Database tests fail on SQLite

Background

I first mentioned this issue as a comment in #2373745: Combine fields filter with missing field(s) results in fatal error: Call to a member function ensure_my_table() on a non-object, and decided to separate this as a separate issue.

Comments

Comment #1

rudiedirkx CreditAttribution: rudiedirkx commented 16 May 2015 at 14:42

Did you actually reproduce this? Because it works fine for me.

I fetch Title and Background color
Exclude Background color
Exposed filter like you describe
Search for "green"

This is the resulting query:

SELECT node.title AS node_title, node.nid AS nid, 'node' AS field_data_field_bgcolor_node_entity_type
FROM {node} node
LEFT JOIN {field_data_field_bgcolor} field_data_field_bgcolor ON node.nid = field_data_field_bgcolor.entity_id AND (field_data_field_bgcolor.entity_type = 'node' AND field_data_field_bgcolor.deleted = '0')
WHERE (( (CONCAT_WS(' ', node.title, ' ', field_data_field_bgcolor.field_bgcolor_value) LIKE '%green%') ))
LIMIT 10 OFFSET 0

As you can see both node.title and field_data_field_bgcolor.field_bgcolor_value are searched. And the results back that up: 1 result with "green" as Background color.