Problem/Motivation

When a forum has a new topic, the forum list at /forum shows that there is a new topic in the forum, but does not show the starred speech bubble next to the forum name.

Current/Broken:

broken forum list icon

Expected:

expected forum list icon

Proposed resolution

Cleanup CSS classes and bring them into alignment with [1887918]
I took a look at [1887918]

This is what I came up with for some new CSS, so far:

/forum

.forums
.forums__forum
.forums__forum--[variant]
.forums__forum__icon
.forums__forum__name

/forum/{taxonomy_term}

.forum
.forum__topic
.forum__topic--[variant]
.forum__topic__icon
.forum__topic__meta

Here are some images that highlight where these classes would apply.

/forum

Only local images are allowed.

/forum/{taxonomy_term}

Only local images are allowed.

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Embed before and after screenshots in the issue summary Novice Instructions

User interface changes

API changes

None

CommentFileSizeAuthor
#19 new.png12.55 KBquiron
#19 nonew.png11.64 KBquiron
#5 forum-indicator-status-2489374-4.patch373 bytescolinafoley
#2 new-topic.png16.36 KBdixon_
#1 bartik-forum-indicator-2489374-1.patch351 bytescolinafoley
forum_list_expected_indicator.png18.66 KBcolinafoley
forum_list_broken_indicator.png18.43 KBcolinafoley
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

colinafoley’s picture

colinafoley CreditAttribution: colinafoley at Lehigh University commented
Status: Active » Needs review
FileSize
bartik-forum-indicator-2489374-1.patch351 bytes
dixon_’s picture

dixon_
he/him
Primary language English
Location France
CreditAttribution: dixon_ at Pfizer, Inc. for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community
FileSize
new-topic.png16.36 KB

Very straight forward fix. Code looks good. I've applied the patch and it works.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Assigned: colinafoley » Unassigned
Issue tags: +CSS, +frontend
colinafoley’s picture

colinafoley CreditAttribution: colinafoley at Lehigh University commented
Status: Reviewed & tested by the community » Needs work

Just realized this should be in forum.theme.css not Bartik

O_o

colinafoley’s picture

colinafoley CreditAttribution: colinafoley at Lehigh University commented
Title: Bartik - forum status indicator does not respect forum status » Forum - forum status indicator does not respect forum status
Status: Needs work » Needs review
FileSize
forum-indicator-status-2489374-4.patch373 bytes
colinafoley’s picture

colinafoley CreditAttribution: colinafoley at Lehigh University commented
Title: Forum - forum status indicator does not respect forum status » Forum - status indicator does not respect forum status
colinafoley’s picture

colinafoley CreditAttribution: colinafoley at Lehigh University commented
Component: Bartik theme » forum.module
mortendk’s picture

mortendk CreditAttribution: mortendk commented
Status: Needs review » Reviewed & tested by the community

We should create a followup issue that fixed the crappy css names, but this patch works as it should :)

colinafoley’s picture

colinafoley CreditAttribution: colinafoley at Lehigh University commented
Issue summary: View changes
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Reviewed & tested by the community » Needs work

So there is already a class for this called "forum__topic-status--new" so we just have to fix the class that gets output.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer commented
Issue tags: +CSS regressions
YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue summary: View changes

adding link to the issue summary, remaining tasks for adding before and after screenshots

colinafoley’s picture

colinafoley CreditAttribution: colinafoley at Lehigh University commented
Issue summary: View changes

I took a look at [1887918]

This is what I came up with for some new CSS, so far:

/forum

.forums
.forums__forum
.forums__forum--[variant]
.forums__forum__icon
.forums__forum__name

/forum/{taxonomy_term}

.forum
.forum__topic
.forum__topic--[variant]
.forum__topic__icon
.forum__topic__meta

Here are some images that highlight where these classes would apply.

/forum

Only local images are allowed.

/forum/{taxonomy_term}

Only local images are allowed.

colinafoley’s picture

colinafoley CreditAttribution: colinafoley at Lehigh University commented
Issue summary: View changes

This issues might need a title change at this point.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer commented

So the classy/dataset/forum-icon.html.twig has this:

{%
  set classes = [
    'forum__icon',
    'forum__topic-status--' ~ icon_status,
  ]
%}
<div{{ attributes.addClass(classes) }}>
  {% if first_new -%}
    <a id="new"></a>
  {%- endif %}
  <span class="visually-hidden">{{ icon_title }}</span>
</div>

So shouldn't that already add forum__topic-status--new when icon_status is new?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

quiron’s picture

quiron
Primary language Catalan
Location Barcelona
CreditAttribution: quiron commented
FileSize
nonew.png11.64 KB
new.png12.55 KB

Hi,

with a Drupal 8.2.7 clean out of the box seems working properly. Attaching the image of the same site state with 2 different users.

$ drush config-get system.theme
admin: seven
default: bartik
_core:
  default_config_hash: XXXX

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude as a volunteer and at iO commented
Issue tags: +Bug Smash Initiative

Tested in 10.1 and still broken

As @larowlan pointed out in #15 we would expect the right class to get added, but it doesn't...because the list template doesn't use the icon template to generate the icons!

See for example core/profiles/demo_umami/themes/umami/templates/classy/dataset/forum-list.html.twig

          <div class="forum__icon forum-status-{{ forum.icon_class }}" title="{{ forum.icon_title }}">
            <span class="visually-hidden">{{ forum.icon_title }}</span>
          </div>

So that should probably use the icon template? Maybe? Or should we just add the correct class in the list template too?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan as a volunteer commented
Priority: Normal » Minor
Issue tags: +Needs tests, +Novice

I think we should just add the icons in the list template, the icon template looks to have a id=new attribute that wouldn't make sense in a list (judging by my comment above)

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Needs work » Postponed

Forum is approved for removal. See #1898812: [policy] Deprecate forum module for removal in Drupal 11

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

It will be moved to the contributed extension once the Drupal 11 branch is open.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.