In #2488554: Automatic registration of CSS files as libraries, libraries can be automatically registered for single 'css' files so that we don't need to have the *.libraries.yml for any of the Display Suite layouts, by switching from the 'library' key to 'css'. Let's do it!

CommentFileSizeAuthor
#1 ds-layout_plugin-library-2488888-1.patch3.72 KBdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Needs review
FileSize
ds-layout_plugin-library-2488888-1.patch3.72 KB

This patch depends on #2488550: Update Display Suite for automatic registration of layout templates, so let's merge that one first.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

layout_plugin 1.0-alpha11 has been released:

https://www.drupal.org/node/2499025

So, this patch should be ready to review!

  • aspilicious committed 4ed803f on 8.x-2.x authored by dsnopek 
    Issue #2488888 by dsnopek: Update Display Suite for automatic...
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Fixed

Thnx!

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Got a couple of test fails.
Pasting the bot link as reminder: https://qa.drupal.org/pifr/test/881633

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

I've been attempt to run the tests locally so that I can try and figure out what's going on. However, I can't seem to figure out how to do it!

Normally, I do something like:

cd core
./vendor/bin/phpunit --group ds

But I keep getting:

No tests executed!

Any suggestions? Thanks!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Er, heh, I've gotten so used to using PHPUnit with Drupal 8, I almost completely forgot about Simpletest! :-) Sorry for the noise, I figured out how to run the tests.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

I reverted DS to revision f931cdc (the one before the layout plugin commits) and ran the SimpleTests and I got the same failures. :-/ So, maybe they aren't related to the layout_plugin changes, but changes in D8 core?

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Ok thnx for the effort. Next week I'll try to debug the fails that looks suspicious to me.