Device detect block module provide a tab to configure block visibility at different Devices. It provides you to choose show block in Desktop, tab and mobile device. It keeps all the configuration in its created table in database.

Sandbox url

https://www.drupal.org/sandbox/vks7056/2488456

Git Clone command

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/vks7056/2488456.git device_detect_block

Features

This Module adds a extra tab in block configure page, so the user can set block visibility based on device.

Goal

Providing the flexibility to Show/hide Block on mobile devices.

Comments

Vikas.Kumar’s picture

Issue summary: View changes
Vikas.Kumar’s picture

Issue summary: View changes
Vikas.Kumar’s picture

Issue summary: View changes
Vikas.Kumar’s picture

Status: Active » Needs review
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxvks70562488456git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

tikaszvince’s picture

Automated Review

Pareview.sh show some CodeSniffer errors http://pareview.sh/pareview/httpgitdrupalorgsandboxvks70562488456git

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[No: Causes] module duplication and/or fragmentation.
Please compare with Mobile Detect Block.
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[Yes: Follows] the the guidelines for in-project documentation.
[No: Does not follow] the README Template.
Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
I haven't done any security review
Coding style & Drupal API usage
Please fix all of the code style issues reported by pareview.sh

This review uses the Project Application Review Template.

Vikas.Kumar’s picture

Status: Needs work » Active

Hi tikaszvince, Thank you for your valuable review, I appreciate your time and effort to sort out the issues. This module is not similar to Mobile detect block. I am having plan to expand it further, So that user can show a block in different regions depends on device. Another challenge to work it properly at cache enabled site. Your valuable suggestions are always welcome.

Vikas.Kumar’s picture

Status: Active » Needs review
prajaankit’s picture

Issue tags: +PAreview: review bonus

Hi vikas i see your project in your code have some coding stanbderd error please remove that
using the link http://pareview.sh/
vikas you do the change by using net beans make the setting to drupal coding standerd
please see this link to set up you netbeans https://www.drupal.org/node/1019816

FILE: /var/www/drupal-7-pareview/pareview_temp/device_detect_block.install
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
43 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/device_detect_block.module
---------------------------------------------------------------------------
FOUND 10 ERRORS AND 3 WARNINGS AFFECTING 12 LINES
---------------------------------------------------------------------------
4 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
5 | ERROR | [x] There must be exactly one blank line before the tags
| | in a doc comment
6 | ERROR | [ ] There must be exactly one blank line after the file
| | comment
12 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
13 | ERROR | [ ] Doc comment short description must be on a single
| | line, further text should be a separate paragraph
14 | ERROR | [x] There must be exactly one blank line before the tags
| | in a doc comment
55 | ERROR | [x] There must be exactly one blank line before the tags
| | in a doc comment
59 | ERROR | [ ] If the line declaring an array spans longer than 80
| | characters, each element should be broken into its
| | own line
69 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", or "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.".
71 | ERROR | [ ] Doc comment short description must be on a single
| | line, further text should be a separate paragraph
74 | ERROR | [ ] No space before comment text; expected "// print
| | ""; print_r($blocks);exit;" but found "//print
| | ""; print_r($blocks);exit;"
74 | ERROR | [ ] Inline comments must start with a capital letter
125 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/device_detect_block.js
---------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
---------------------------------------------------------------------------
1 | ERROR | [ ] Missing file doc comment
3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
5 | ERROR | [ ] Doc comment short description must be on a single line,
| | further text should be a separate paragraph
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
24 | ERROR | [x] Expected 1 newline at end of file; 2 found
25 | ERROR | [x] Additional whitespace found at end of file
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/device_detect_block.info
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------

klausi’s picture

Issue tags: -PAreview: review bonus

@prajaankit: removing review bonus, you should only add this to your own application. Please read https://www.drupal.org/node/1975228 again.

Vikas.Kumar’s picture

Issue summary: View changes
klausi’s picture

Issue summary: View changes

fixed git clone command

klausi’s picture

Status: Needs review » Closed (duplicate)

The code in the repository is an identical clone from https://www.drupal.org/project/browscap_block . Instead of creating a new project and presenting this as if it were your own work you should collaborate with the existing project instead. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the browscap_block issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Also, next time you fork a project you must give credit on the project page where you copied the code from to avoid any confusion.

apaderno’s picture

Title: Device Detect Block » [D7] Device Detect Block
Status: Closed (duplicate) » Closed (won't fix)
apaderno’s picture

Status: Closed (won't fix) » Closed (duplicate)
Related issues: +#3144721: [D8] Webform Background Color Scheme