Scheduler options not saving

You can find the code that was originally handling this is in scheduler_node_validate(). In Drupal 8 hook_node_validate() was removed. This is the change record: hook_node_validate() and hook_node_submit() have been removed.

Seems like we need to implement some validation constraints!

Looking very good. When testing it out I get a fatal error when viewing the node, but that's a different issue, I'll make a follow-up about it.

1. +++ b/scheduler.edit.inc
   @@ -148,6 +149,15 @@ function _scheduler_form_alter(array &$form, FormStateInterface $form_state) {
   +/**
   + * Entity builder for nodes with scheduler options.
   + */
   +function scheduler_node_builder($entity_type, NodeInterface $node, &$form, FormStateInterface $form_state) {
   +  $node->publish_on = $form_state->getValue('publish_on');
   +  $node->unpublish_on = $form_state->getValue('unpublish_on');
    }
   

   I would move this out of scheduler.edit.inc and into scheduler.module. The edit page is only included when an actual form alter takes place and might not be included when a cached form is reused. I can imagine that this would break in special cases such as multistep forms, inline entity forms etc.

2. +++ b/scheduler.module
   @@ -449,10 +449,12 @@ function scheduler_node_presave(EntityInterface $node) {
   -    $publish_immediately = variable_get('scheduler_publish_past_date_' . $node->getType(), 'error') == 'publish';
   

   Ah so there were some calls left to variable_get()? Nice catch!

3. +++ b/scheduler.module
   @@ -449,10 +449,12 @@ function scheduler_node_presave(EntityInterface $node) {
   +    $type = $node->type->entity;
   

   This looks strange to me but it works and I could not find a better way to do it.

   $node->getEntityType() returns the definition instead of the entity, so that's not the right solution.

   I guess it's fine for now.

So the only thing that needs to be done is moving the entity builder function to scheduler.module.

Created followup issue for the fatal error: #2495011: Fatal error when viewing a scheduled node.

Thanks a lot! Merged into 8.x-1.x.