Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#8 | 2487047-stripe_api_version.patch | 339 bytes | chertzog |
#5 | add_composer_install-2487047-5.patch | 2.26 KB | yanniboi |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedMore details on this now...
We should add a hook_requirements temporarily until #2494073: Prevent modules which have unmet Composer dependencies from being installed closes. This will enable https://www.drupal.org/project/composer_manager to alert users that the requirements are not met.
In the future, users can use https://www.drupal.org/node/2627292.
Working on a patch for this issue is documented here: https://www.drupal.org/node/2405811.
This will make it so "composer install" is NOT required in the module folder.
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #4
yanniboi CreditAttribution: yanniboi at FreelyGive commentedYup composer_manager is the way forward. Maybe as part of this we should rewrite the composer.json to conform with drupal packagist standards? Eg:
Comment #5
yanniboi CreditAttribution: yanniboi at FreelyGive commentedHere is a hook_requirements implementation and I've updated the code to pull from Drupal's vendor and autoload using composer manger rather than running composer install in the module directory.
Comment #6
yanniboi CreditAttribution: yanniboi at FreelyGive commentedI've manually tested this patch and composer_manager finds the dependency and a payment using test api keys works.
Comment #7
jochemvn CreditAttribution: jochemvn for Open Social commentedAnother problem that's currently there is the fact that trying to install with composer starts checking the info.yml file and stumbles upon the line:
With stripe_api currently at: 8.x-1.0-alpha1 this won't work. Composer throws:
will the composer.json for this project be updated anytime soon?
by the way. I've tried applying the patch with "cweagans/composer-patches", but that also didn't work.
Comment #8
chertzogHere is a patch that removes the version requirement. which should allow this to work with composer.
Comment #9
eiriksmLooks good, please commit :)
Comment #10
grasmash CreditAttribution: grasmash at Acquia commentedComment #11
grasmash CreditAttribution: grasmash at Acquia commentedPatch fails to apply against dev.