Problem/Motivation

The commit http://drupalcode.org/project/captcha.git/commit/c43bcc5 has changed the defaults incorrectly and does not follow core code style.

Proposed resolution

Rollback half patch

Remaining tasks

None

User interface changes

None

API changes

None

Original report:

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for captcha.settings with the following errors: 
captcha.settings:administration_mode variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData, 
captcha.settings:allow_on_admin_pages variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData, 
captcha.settings:add_captcha_description variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData, 
captcha.settings:enable_stats variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData, 
captcha.settings:log_wrong_responses variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData 
in Drupal\Core\Config\Testing\ConfigSchemaChecker->onConfigSave() (line 98 of /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Config/Testing/ConfigSchemaChecker.php). Drupal\Core\Config\Testing\ConfigSchemaChecker->onConfigSave(Object, 'config.save', Object) Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('config.save', Object) Drupal\Core\Config\Config->save(1) Drupal\Core\Config\ConfigInstaller->createConfiguration('', Array) Drupal\Core\Config\ConfigInstaller->installDefaultConfig('module', 'captcha') Drupal\Core\Extension\ModuleInstaller->install(Array, 1) Drupal\simpletest\WebTestBase->setUp() Drupal\recaptcha\Tests\ReCaptchaBasicTest->setUp() Drupal\simpletest\TestBase->run(Array) simpletest_script_run_one_test('1', 'Drupal\recaptcha\Tests\ReCaptchaBasicTest')
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass’s picture

Status: Active » Needs review
FileSize
905 bytes

This should fix the issue that breaks my reCAPTCHA test runs, see https://qa.drupal.org/pifr/test/1029843

hass’s picture

Title: Schema errors: captcha.settings:administration_mode variable type is integer » Schema errors: captcha.settings
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 1: Issue-2486067-by-hass-Fix-invalid-values-in-settings.patch, failed testing.

hass’s picture

Issue summary: View changes
Status: Needs work » Needs review

hass’s picture

Title: Schema errors: captcha.settings » Rollback changed defaults and use lowercase boolean value
hass’s picture

New patch for latest settings file.

hass’s picture

Issue summary: View changes
hass’s picture

Issue summary: View changes
Berdir’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine.

wundo’s picture

wundo’s picture

Status: Reviewed & tested by the community » Fixed

  • wundo committed 4dfbdc0 on 8.x-1.x authored by hass
    Issue #2486067 by hass, lks90, Berdir, wundo: Rollback changed defaults...

The last submitted patch, 1: Issue-2486067-by-hass-Fix-invalid-values-in-settings.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 7: Issue-2486067-by-hass-Rollback-changed-defaults-and-.patch, failed testing.

Berdir’s picture

Status: Needs work » Fixed

Branch tests green again :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.