When you receive.

Notice: Undefined offset: 0 in Drupal\office_hours\Plugin\Field\FieldWidget\OfficeHoursWidget->errorElement() (line 264 of profiles/hungry_kickstart/modules/contrib/office_hours/src/Plugin/Field/FieldWidget/OfficeHoursWidget.php).

error

Patch attached

CommentFileSizeAuthor
#5 OfficeHours-2485407-3-patch_error_element_fail_because_empty_error.patch574 bytesMschudders
#3 OfficeHours-2485407-3-patch_error_element_fail_because_empty_error.patch583 bytesMschudders
#1 2485407-1-patch_error_element_fail_because_empty_error.patch662 bytesMschudders
patch_error_element_fail_because_empty_error.patch662 bytesMschudders
error.png84.97 KBMschudders
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mschudders’s picture

Mschudders CreditAttribution: Mschudders commented
FileSize
2485407-1-patch_error_element_fail_because_empty_error.patch662 bytes

patch following coding standards added

Mschudders’s picture

Mschudders CreditAttribution: Mschudders at Randstad Digital commented
Mschudders’s picture

Mschudders CreditAttribution: Mschudders at Randstad Digital commented
FileSize
OfficeHours-2485407-3-patch_error_element_fail_because_empty_error.patch583 bytes
Mschudders’s picture

Mschudders CreditAttribution: Mschudders at Randstad Digital commented
Mschudders’s picture

Mschudders CreditAttribution: Mschudders at Randstad Digital commented
FileSize
OfficeHours-2485407-3-patch_error_element_fail_because_empty_error.patch574 bytes
johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Title: Undefined offset: 0 in Drupal\office_hours\Plugin\Field\FieldWidget\OfficeHoursWidget->errorElement » Undefined offset: 0 in OfficeHoursWidget->errorElement
Priority: Major » Normal
Status: Needs review » Fixed

I could not replicate this error, since it is not possible to enter an invalid value in the widget.
Nonetheless, your patch reverts the function to its superclass, so I removed the function completely.

Committed with attribution.

  • johnv committed f75ab01 on 8.x-1.x authored by Mschudders 
    Issue #2485407 by Mschudders:  Undefined offset: 0 in OfficeHoursWidget...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.