Faced problem on multilingual site where protected_node module is used. Possible solution is to replace key 'und' with constant LANGUAGE_NONE

CommentFileSizeAuthor
#5 protected_node-use_language_none_instead_of_und-2484783-5.patch6.96 KBGrimreaper
#1 replace_und_with_language_none-2484783-1.patch6.38 KBuladzimir.karol
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

uladzimir.karol’s picture

uladzimir.karol CreditAttribution: uladzimir.karol commented
FileSize
replace_und_with_language_none-2484783-1.patch6.38 KB

Here is my quick fix 'und'->LANGUAGE_NONE for protected_node

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper commented
Status: Active » Needs review

Thanks.

Changing in needs review to start the automated tests.

Status: Needs review » Needs work

The last submitted patch, 1: replace_und_with_language_none-2484783-1.patch, failed testing.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper commented
Status: Needs work » Postponed (maintainer needs more info)

Hello,

I made the modifications in your patch myself and there is no problem.

But could you please give the steps to reproduce the bug?

Because the modifications are made only in test files.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper commented
FileSize
protected_node-use_language_none_instead_of_und-2484783-5.patch6.96 KB

Uploading an applicable patch.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Title: Replace 'und' with the constant LANGUAGE_NONE for multi language site in protected_node » Replace 'und' with the constant LANGUAGE_NONE
Category: Bug report » Task
Status: Postponed (maintainer needs more info) » Fixed

Hello,

This is now merged as it is a good practice to use the constant LANGUAGE_NONE instead of 'und'. I changed the issue metadata and title bucause it was not a bug. I can't find the documentation page about this constant.

Here is the documentation page about how to provide a patch because your patch was not applyable: https://www.drupal.org/node/707484

Thanks for helping

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.