Missing argument 3 for uc_payment_method_credit_form() [#2484073]

In the line (on 1291 for me due to an pplied patch, but on line 1288 for the patch) of file uc_recurring/modules/uc_recurring_hosted/uc_recurring_hosted.module

$form['cc_data'] += uc_payment_method_credit_form(array(), $order);

the function uc_payment_method_credit_form is called with the wrong number of arguments, $form_state is not passed to it as the second argument...

The line should be

$form['cc_data'] += uc_payment_method_credit_form(array(), $form_state, $order);

I have created a patch.

Comment	File	Size	Author
#5	uc_recurring-uc_country_select_function_removed-2484073-5.patch	2.11 KB	DrCord
#2	uc_recurring-_missing_argument_for_uc_payment_method_credit_form-2484073-1.patch	715 bytes	DrCord

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

DrCord CreditAttribution: DrCord commented 6 May 2015 at 15:49

Issue summary:

View changes

Comment #2

DrCord CreditAttribution: DrCord commented 6 May 2015 at 15:52

File	Size
uc_recurring-_missing_argument_for_uc_payment_method_credit_form-2484073-1.patch	715 bytes

Here is a patch for this issue.

Comment #3

DrCord CreditAttribution: DrCord commented 6 May 2015 at 16:02

Issue summary:

View changes

Comment #4

DrCord CreditAttribution: DrCord commented 6 May 2015 at 16:03

Issue summary:

View changes

Comment #5

DrCord CreditAttribution: DrCord commented 6 May 2015 at 17:02

File	Size
uc_recurring-uc_country_select_function_removed-2484073-5.patch	2.11 KB

1 file was hidden/shown/deleted

File	Size
uc_recurring-_missing_argument_for_uc_payment_method_credit_form-2484073-1.patch	715 bytes

As I was going through the file more I found other instances of the exact same problem. I created a patch that fixed all of these and a nearby use of the $user variable without it being available.