Remove some unneeded roles: translation team member, (passive member?) in a l10n_groups_update_N().

Comments

  • opdavies committed 5973518 on 7.x-1.x
    Issue #2483423: Remove some unneeded roles
    

opdavies’s picture

Status: Active » Fixed

Done, but in localizedrupalorg rather than l10_server.

Gábor Hojtsy’s picture

Status: Fixed » Needs work

Why were these roles unneeded? The passive member role was a tool for admins to block people indefinitely if they desire so. Otherwise they can only boot them from the team which they can then join again. Unfortunately we needed this feature to keep some unreasonable people in check. Also the team member role is/was used as a group level role to grant permissions to submit suggestions, etc. How is this managed now? Why are the other group level permissions needed still then if these two are not?

opdavies’s picture

I'll re-add these roles.

opdavies’s picture

The site-wide roles were removed, but the per-group roles still exist. Is this the desirable state, or do we need the site-wide roles too?

Gábor Hojtsy’s picture

Ah!

TRANSLATION COMMUNITY MANAGER; TRANSLATION COMMUNITY MODERATOR and TRANSLATION SELF-MODERATOR are not needed as global roles either, should be removed too.

I see the group level roles are at https://localize-7.staging.devdrupal.org/admin/config/group/roles/node/l.... I hope once they are removed globally they would still be there and migrated there properly?

  • opdavies committed 32807d4 on 7.x-1.x
    Issue #2483423: Remove some more roles
    
opdavies’s picture

TRANSLATION COMMUNITY MANAGER; TRANSLATION COMMUNITY MODERATOR and TRANSLATION SELF-MODERATOR are not needed as global roles either, should be removed too.

These have now been removed.

I hope once they are removed globally they would still be there and migrated there properly?

The roles are still there on my dev site after removing the global roles. I assume that the group specific memberships and role assignments are already in place on the D7 site?

opdavies’s picture

Status: Needs work » Needs review
opdavies’s picture

Pushed to staging.

Gábor Hojtsy’s picture

Status: Needs review » Fixed

This looks good. I think there may be some problems with permissions still, based on a cursory look but those would be the realm of #1666262: Verify permissions after D7 upgrade.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.