Problem/Motivation

Exporting configurations is now supported and helps with performance when creating an array from the schema file. Since a recent change, ConfigEntityType annotation can declare an array of config entities to export, which saves a lot of time, for example during site install.

Proposed resolution

Apply the patch.

Remaining tasks

None

User interface changes

None

API changes

None

CommentFileSizeAuthor
#6 configExport_2483325_4.patch8.57 KBLKS90
#4 configExport_2483325_3.patch8.66 KBLKS90
#3 configExport_2483325_2.patch1.7 KBLKS90
#1 configExport_2483325_1.patch773 bytesLKS90
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LKS90’s picture

LKS90 CreditAttribution: LKS90 at MD Systems GmbH commented
Status: Active » Needs review
FileSize
configExport_2483325_1.patch773 bytes

The patch the issue mentioned.

Status: Needs review » Needs work

The last submitted patch, 1: configExport_2483325_1.patch, failed testing.

LKS90’s picture

LKS90 CreditAttribution: LKS90 at MD Systems GmbH commented
FileSize
configExport_2483325_2.patch1.7 KB

Updated version with default configuration fixed with correct types (as far as I can in the module, see #2485357)

LKS90’s picture

LKS90 CreditAttribution: LKS90 at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
configExport_2483325_3.patch8.66 KB

Defined the default config inside the module until the core issue #2485357 is fixed.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented 
+++ b/config/install/core.entity_form_display.node.simplenews_issue.default.yml
@@ -28,9 +21,46 @@ content:
+  path:
+    type: path
+    weight: 30
+    settings: {  }
+    third_party_settings: {  }

path problem again ;)

Don't add this one, because this will then add a dependency on path (which you didn't add, but if you would have, would have broken tests)

LKS90’s picture

LKS90 CreditAttribution: LKS90 at MD Systems GmbH commented
FileSize
configExport_2483325_4.patch8.57 KB

Removed the path block from the default config, new patch.

Status: Needs review » Needs work

The last submitted patch, 6: configExport_2483325_4.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Fixed

Committed, the remaining fails are random/missing dependencies.

  • Berdir committed b407fd4 on 8.x-1.x authored by LKS90 
    Issue #2483325 by LKS90: Add config_export to Newsletter...

The last submitted patch, 4: configExport_2483325_3.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.