Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi, I saw this issue, but I needed to patch the makefile for the 3.3 version, so here it is.
| Comment | File | Size | Author |
|---|---|---|---|
| iCalcreator_version-2482643-5.patch | 586 bytes | maxocub |
Comments
Comment #1
coredumperror CreditAttribution: coredumperror commentedThanks for the heads up. I actually fixed this issue, and even applied the exact change you had in your patch, a few hours ago. You should be able to get the updated make file from the lastest dev build.
Comment #2
maxocub CreditAttribution: maxocub commentedYes, I saw, but I don't want to use the dev branch for production sites. We use recursive makefiles, so I needed your changes to the makefile on the 3.3 branch.
Was there a better way for me to achieve that?
Comment #3
coredumperror CreditAttribution: coredumperror commentedPerhaps I misinterpreted your intent in posting this patch to the issue queue. Why did you post it here, when there's already an identical change in the dev release?
Comment #4
maxocub CreditAttribution: maxocub commentedSorry about this confusion, the patch is mostly for my use (or anyone who want to patch their 3.3 version without the need to switch to the dev release).
I needed a patch to put in my makefile so the 3.3 version would install the previous version of iCalcreator, like that:
This way I can keep the date_ical 3.3 release with the iCalcreator 2.20.2 release.
I wasn't asking you to apply this patch to the dev branch (since you already did so), I was just giving myself an URL to a patch I can use on 3.3.
Hope it's clearer!
Comment #5
coredumperror CreditAttribution: coredumperror commentedOK, I get what you were doing, now. Since you just needed it for yourself, though, would you have been able to put it on a server you own, instead of posting it to this issue queue?
And for future reference, I never push a change to Date iCal's git server until it's been thoroughly tested. So, like many other modules these days, the dev releases are safe for use in production.
Comment #6
maxocub CreditAttribution: maxocub commentedYeah, you're right, I definitly could have put it on my own server. But then again, maybe I'm not the only one who is in that situation and need that patch.
I believe you with the stability of the dev branch, and normaly I would use it, but in my current situation, I just can't use a non-fixed version that can be modified any time.
Sorry for this duplicate.
Comment #7
coredumperror CreditAttribution: coredumperror commentedSomeone else ran into the iCalcreator problem, so I realized that I clearly needed to make a new commended release to avoid future foulups. Date iCal 7.x-3.4 is now available, which includes this change. So you don't need to use a patched version of 3.3 any more.