Split view and edit permissions

Hello,

I think it would have been better to re-open the related issue.

Are you ok with this permission matrix?

Hello,

I agree that your labels are easier to understand, so the permission matrix is more natural.

Just waiting the opinion of Izus the other co-maintainer. If it is ok, I will make the patch.

To complete the matrix, for features which add tabs on the node like webform, or the node/nid/delete. I don't know if those responsibilities should be in "edit protected content (bypass password)" or in two permissions like "delete protected content (bypass password)" and "access protected content other tabs (bypass password)"

Hi,
i agree with the split

let's not use the terme 'dialog' as this is a waanted feature that is not in for the moment (we just redirecte to a form) and let's also be clear with terms : edit any password => edit any protected node password

i also think that the module should keep on "view" part and not deal with the delete operation.

we'll need to set new permissions automatically (hoo_update_n) to not break existing site permissions

a clear matrix in the readme.txt would begreat too :)

Hello,

Here is a patch that change the permissions.

Thanks to test and review it.

When it will be ok, I will also update the README.txt and the online documentation.

1. +++ b/protected_node.module
   @@ -75,27 +75,35 @@ function protected_node_help($path, $arg) {
   +    'access password form' => array(
   

   access protected node password form

2. +++ b/protected_node.module
   @@ -75,27 +75,35 @@ function protected_node_help($path, $arg) {
        'edit any password' => array(
   

   can we also change this to "edit any protected node password", would be clearer

Thanks

Thanks for the suggestions.

I remade the patch with.

Waiting any feedback before merging.

Before the patch we had 3 permissions:
'access protected content'
'bypass password protection'
'edit any password'

After the patch we have 5 permissions:
'access protected node overview page'
'access protected node password form'
'edit any protected node password'
'view protected content'
'edit protected content'

The 5 permissions are all new ones. In order to not break permission system of existing sites we should handle all the new permissions default configuration based on the old permissions

Hello,

Just in time, I was about to merge :)

'access protected node overview page' <- 'administer site configuration'
'access protected node password form' <- 'access protected content' DONE
'edit any protected node password' <- 'edit any password' DONE
'view protected content' <- 'bypass password protection' ???
'edit protected content' <- 'bypass password protection' DONE

If you are ok with this mapping I will update the patch.

I will also have to update the README.txt and the documentation page.

yeah i think something like this will do it :)

Ok, finally I have done:

'access protected node overview page' <- 'bypass password protection'
'access protected node password form' <- 'access protected content'
'edit any protected node password' <- 'edit any password'
'view protected content' <- 'bypass password protection'
'edit protected content' <- 'bypass password protection'

Currently it is bypass password protection for the overview page. And I have added the matrix in the README.txt

Thanks for the review.

read the code quickly and seems good.
letting someone that applies it and tested interface mark it as RTBTC or to Grimreaper to retest and merge :)

Ok, thanks.

I will wait a few days (3 - 7) or until someone else respond to merge.

Rebasing the patch.

This is now merged.

Thanks all.