Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
protected $ignoredEntities = [
'flagging',
I don't see a reason to disallow flagging flaggings. Though I suppose if you have your flaggings flag, you could then flag the flaggings you made with this actual flag... could get painful.
Comment | File | Size | Author |
---|---|---|---|
#9 | 2481795-9.patch | 948 bytes | giancarlosotelo |
#6 | unnecessary_flagging_in-2481795-6.patch | 620 bytes | Pravin Ajaaz |
#2 | unnecessary_flagging_in-2481795-2.patch | 464 bytes | Pravin Ajaaz |
Comments
Comment #1
joachim CreditAttribution: joachim commentedUpdating and tagging.
Comment #2
Pravin Ajaaz CreditAttribution: Pravin Ajaaz as a volunteer and at Ameex-Drupal Geeks commentedRemoved flagging from $ignoredEntities.
Comment #3
Pravin Ajaaz CreditAttribution: Pravin Ajaaz as a volunteer and at Ameex-Drupal Geeks commentedComment #5
joachim CreditAttribution: joachim commentedWe can probably just pull the whole 'ignored entities' functionality, I think.
Comment #6
Pravin Ajaaz CreditAttribution: Pravin Ajaaz as a volunteer and at Ameex-Drupal Geeks commentedLet me remove it entirely.
Comment #7
Pravin Ajaaz CreditAttribution: Pravin Ajaaz as a volunteer and at Ameex-Drupal Geeks commentedComment #9
giancarlosotelo CreditAttribution: giancarlosotelo at MD Systems GmbH commentedIf we are removing it completely, we should also remove the 'if' with the variable in the loop.
Comment #11
joachim CreditAttribution: joachim commentedYup, well spotted.
Committed. Thanks everyone.