protected $ignoredEntities = [
    'flagging',

I don't see a reason to disallow flagging flaggings. Though I suppose if you have your flaggings flag, you could then flag the flaggings you made with this actual flag... could get painful.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

Title: unnecessary flag and flagging in EntityFlagTypeDeriver::$ignoredEntities » unnecessary flagging in EntityFlagTypeDeriver::$ignoredEntities
Issue summary: View changes
Issue tags: +Novice

Updating and tagging.

Pravin Ajaaz’s picture

Removed flagging from $ignoredEntities.

Pravin Ajaaz’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: unnecessary_flagging_in-2481795-2.patch, failed testing.

joachim’s picture

We can probably just pull the whole 'ignored entities' functionality, I think.

Pravin Ajaaz’s picture

Let me remove it entirely.

Pravin Ajaaz’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: unnecessary_flagging_in-2481795-6.patch, failed testing.

giancarlosotelo’s picture

Status: Needs work » Needs review
FileSize
948 bytes

If we are removing it completely, we should also remove the 'if' with the variable in the loop.

  • joachim committed ee6f85d on 8.x-4.x authored by Pravin Ajaaz
    Issue #2481795 by Pravin Ajaaz, giancarlosotelo: Removed ignoring of...
joachim’s picture

Status: Needs review » Fixed

Yup, well spotted.

Committed. Thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.