Problem/Motivation

FlagCountManagerInterface::getUserCounts() expects a flag and user object and calls methods on each in order to function. Without type hinting, the call could fail due to the wrong type of class.

Proposed resolution

Add type hinting to FlagCountManagerInterface::getUserCounts().

Remaining tasks

Create, test patch.

User interface changes

None.

API changes

FlagCountManagerInterface::getUserCounts() would operate the same, but have additional language level protection against errors.

CommentFileSizeAuthor
#1 2479799.1.getUserCountsTypeHinting.patch1.71 KBsocketwench
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

socketwench’s picture

socketwench CreditAttribution: socketwench commented
Status: Active » Needs review
FileSize
2479799.1.getUserCountsTypeHinting.patch1.71 KB
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented

I think AccountInterface $user should be AccountInterface $account for the consistency.

joachim’s picture

joachim CreditAttribution: joachim commented

I agree -- though on D8 without the global $user there's no longer that security risk.

But best if we only change one thing at a time.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.