cross posting a issue
https://www.drupal.org/node/2479169
as it seems that the '#entity_type' should be filled by protected node module after all!?

CommentFileSizeAuthor
#11 protected_node-use_element_children-2479177-11.patch1.07 KBGrimreaper
#7 protected_node-fix_protected_node_protected_node_hide-2479177-7.patch961 bytesGrimreaper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper commented
Status: Active » Postponed (maintainer needs more info)

Hello,

Please could you give the steps to reproduce the bug?

jan.ptacek’s picture

jan.ptacek CreditAttribution: jan.ptacek commented

here we go,
activate protected_node & eva modules
create a protected node
run a cron job

a watchdog warning will be reported from
function _eva_extract_entity_from_build (source: sites/all/modules/eva/eva.module)
and the cron will die without indexing new content for search etc

jan.ptacek’s picture

jan.ptacek CreditAttribution: jan.ptacek commented
Status: Postponed (maintainer needs more info) » Active
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper commented

Hello,

I think there are steps missing.

I made a fresh Drupal 7 install. eva-7.x-1.2 and the last dev version of protected node.

I followed the steps you mentionned and I have a successful cron execution.

jan.ptacek’s picture

jan.ptacek CreditAttribution: jan.ptacek commented

hi, thank you very much for digging into it!
I'll find out what else is needed to get the _eva_extract_entity_from_build executed.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper commented

I found why I didn't have the error. It was because I had disabled the core search module as I contribute on search_api_attachments.

Now I see it. I will try to provide a patch this weekend.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Assigned: Unassigned » Grimreaper
Status: Active » Needs review
FileSize
protected_node-fix_protected_node_protected_node_hide-2479177-7.patch961 bytes

Hello,

I finally found where the problem was.

In protected_node_protected_node_hide(), $node->content = array() removed the information needed for the other modules.

If this patch is ok, i will merge it.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Assigned: Grimreaper » Unassigned
Status: Needs review » Fixed

Merged.

Thanks for reporting this.

  • Grimreaper committed 32722f6 on 7.x-1.x 
    Issue #2479177 by Grimreaper, jan.ptacek: Fix...
izus’s picture

izus CreditAttribution: izus commented

To stick with Core functions we could have used https://api.drupal.org/api/drupal/includes!common.inc/function/element_c...

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
FileSize
protected_node-use_element_children-2479177-11.patch1.07 KB

Ok, I didn't know that function.

I can merge the following patch if you want.

izus’s picture

izus CreditAttribution: izus commented

i'm ok, We should just add a comment to explain why we need to unset children.
Thanks

  • Grimreaper committed 9403adf on 
    Issue #2479177 by Izus, Grimreaper: Use function element_children to...
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented

Done. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.