I really do not see any logic in \Drupal\user\Form\UserPasswordForm having user_pass as a form id.
This should follow some naming convension principle and should be 'user_password_reset_form' or at least 'user_password_form'.

CommentFileSizeAuthor
#10 core-standardize-form-id-2477335-10.patch954 bytesmmatsoo
#1 user-password-and-reset-form-ids.patch541 bytesAnonymous (not verified)
Use_proper_form_id_for_UserPasswordForm.patch265 bytesAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Title: Use proper form id for UserPasswordForm » Use proper form id for UserPasswordForm and UserPasswordResetForm
FileSize
user-password-and-reset-form-ids.patch541 bytes

Sorry, missed the other form.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Title: Use proper form id for UserPasswordForm and UserPasswordResetForm » Use standardized form id for UserPasswordForm and UserPasswordResetForm
Version: 8.1.x-dev » 8.3.x-dev
  1. Patch no longer applies cleanly against 8.3.x.
  2. I agree with your motivation and change in theory, but I am concerned that making a change to the form id could be disruptive. There may be a great deal of contrib and custom code that depends on this form id.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Needs work

This is a good idea.

But the backwards compatibility policy doesn't say anything about form IDs...

mmatsoo’s picture

mmatsoo CreditAttribution: mmatsoo at Chromatic commented
FileSize
core-standardize-form-id-2477335-10.patch954 bytes

Patch re-rolled against 8.7.x branch.

mmatsoo’s picture

mmatsoo CreditAttribution: mmatsoo at Chromatic commented
Status: Needs work » Needs review
markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Status: Needs review » Reviewed & tested by the community

The patch in #10 looks good and seems to fulfill the mandate of the issue.

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
Status: Reviewed & tested by the community » Needs work

Re #9 This would break any contrib. or custom module currently altering any of these forms. We should maintain BC and deprecate if we think we should pursue this.

Although the form classes are marked @internal, I think

(Even for internal APIs, core contributors should always try to follow the deprecation process first, or document in issue discussions why deprecation is not being used.)

- https://www.drupal.org/core/d8-bc-policy

is something we should do because "the benefits" of changing this value is not really worth all the breaking changes, even if the "fix" is simple.

This should probably also have a CR?

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented

> Re #9 This would break any contrib. or custom module currently altering any of these forms. We should maintain BC and deprecate if we think we should pursue this.

Yes

But I don't think there's yet a way to deprecate a form ID?

cilefen’s picture

cilefen CreditAttribution: cilefen commented

If not, please open an issue for that if none exists and postpone this on it.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.