Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The bible.install just needs some code formatting and layout improvements to be more Drupal coding standard compliant. Some of the other files might need this too, but I'll start here.
ORIGINAL
The bible.install file contains calls to drupal_install_schema() and drupal_uninstall_schema() which causes a fatal error when enabling the module. It doesn't interfere with the running of the module as the schema gets installed regardless, but the install file does need a good cleanup to be more compliant with Drupal standards.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | bible-improve_code_formatting_for_install-2477093-5.patch | 13.5 KB | dieuwe |
| #1 | bible-fatal_errors_on_install-2477093-1.patch | 7.92 KB | dieuwe |
Comments
Comment #1
dieuweThis patch cleans up the entire install file. It removes
bible_install()altogether, removes unnecesary parts ofbible_uninstall(), and applies proper coding conventions to the arrays inbible_schema().Comment #2
berenddeboer CreditAttribution: berenddeboer commentedComment #3
dieuweNote that due to discoveries in #2287261: Branch and Release Cleanup This patch will be invalid as these errors were already resolved in some tags not committed to the dev branch.
The coding style changes to
bible_schema()will probably still be valid, but I will create a separate patch for that in the future once the referenced issue is resolved.Comment #4
dieuweNow that that major issues with the development branch have been cleaned up I shall submit another patch to just improve the code layout in the bible.install file to be more Drupal coding standard compliant.
Comment #5
dieuweThis patch splits all the field definition arrays over different lines to be more readable, fixes indentation, and also adds comments to the two update hooks.
Comment #6
berenddeboer CreditAttribution: berenddeboer commented