Problem/Motivation

contact_storage_entity_base_field_info() still explicitly sets the provider of the ID field, even though this is no longer necessary. The @todo mentions #1498720: [meta] Make the entity storage system handle changes in the entity and field schema definitions which has long been fixed.

Proposed resolution

Remove the call to setProvider().

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#5 2476637-no-more-provider.patch740 bytesjibran
#1 2476637-no-more-provider.patch740 byteststoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at erdfisch commented
Status: Active » Needs review
FileSize
2476637-no-more-provider.patch740 bytes

Here we go.

Berdir queued 1: 2476637-no-more-provider.patch for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#2629540: Mismatched entity and/or field definitions after installing module

This setting looks needed, or should be converted to alter hook.
See related issue about troubles

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Looks that part just need to be moved cos provider is still used
Also related issue stuck with that

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
FileSize
2476637-no-more-provider.patch740 bytes

Re-uploading to test.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Reviewed & tested by the community

It's RTBC for me. @andypost can you expand on #4.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

We have another #2866189: Error on UNISTALL - Mismatched entity and/or field definitions.

  • Berdir committed e682b78 on 8.x-1.x authored by jibran 
    Issue #2476637 by jibran, tstoeckler: Remove obsolete setting of...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

O'Briat’s picture

O'Briat CreditAttribution: O'Briat commented

For those who just uninstall this version of the module, execute the following code (via drush php or via hook_update) :

  $definition_update_manager = \Drupal::entityDefinitionUpdateManager(); 
  if ($content_translation_status = $definition_update_manager->getFieldStorageDefinition('id', 'contact_message')) {
    $definition_update_manager->uninstallFieldStorageDefinition($content_translation_status);
  }