Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GabberMan’s picture

Issue summary: View changes

I had the same problem.

For solve it, go to sites->all->modules->calendar->js and modify the file calendar_colorpicker.js at line 13:
Before:
$(".edit-calendar-colorpicker").live("focus", function(event) {
After
$(".edit-calendar-colorpicker").on("focus", function(event) {

The method live is deprecated in jQuery 1.7

filnug’s picture

Category: Bug report » Feature request
Priority: Major » Critical

Thank you GabberMan.
#1 worked for me.

it should be commit!

asherry’s picture

Version: 7.x-3.5 » 7.x-3.x-dev
Assigned: filnug » Unassigned
Category: Feature request » Bug report
Priority: Critical » Normal
Status: Active » Needs review

That's not going to be a viable fix, .live() was deprecated in favor of .on() in version 1.7 but .on() was only added in version 1.7. This fix will break if the jQuery version is then lower then 1.7, which it will be by default.

I've added a comparison in this patch to make sure it doesn't break with older versions.

I've reduced this priority to Normal as well as it's only a problem with jquery versions higher than 1.7.

asherry’s picture

FileSize
1.46 KB

Added patch.

jmuzz’s picture

This fixed the issue for me.

rlangille’s picture

This is becoming more of an issue now that web application scans are picking up versions of jQuery lower than 1.12.2 as being vulnerable. More sites will be using jQuery update and jQuery Migrate soon. I'd recommend testing and fixing this soon for PCI compliance reasons.

Here's an updated patch with the same basic approach, but that's closer to what's already there, has a simpler comparison function, and a better named focus function.

+1 for cross version compatiblity!

rlangille’s picture

Copy paste mistake when changing function name. Fixing patch.

alasda’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed and tested patch #7. Appears to work as expected.

wylbur’s picture

Neslee Canil Pinto’s picture

Status: Reviewed & tested by the community » Fixed

Committed, Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.