Restore the Taxonomy mapper [#2476115]

With the taxonomy reference field removed (see change record https://www.drupal.org/node/2456869), the FeedsTarget "taxonomy" no longer can be used. As a result, the option "autocreate" is gone for taxonomy references and the test \Drupal\feeds\Tests\Feeds\RssNodeImport fails.

To fix this problem, somehow the FeedsTarget "taxonomy" should be used for when the target type of the entity reference field is "taxonomy_term". In other cases the FeedsTarget "entity_reference" should be used for entity reference fields.

A first patch will follow.

Comment	File	Size	Author
#1	feeds-taxonomy-mapper-2476115-1.patch	4.04 KB	MegaChriz
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

MegaChriz CreditAttribution: MegaChriz commented 22 April 2015 at 19:08

Status:

Active

» Needs review

File	Size
feeds-taxonomy-mapper-2476115-1.patch	4.04 KB

I've now tried to fix this problem by setting the FeedsTarget "taxonomy" field type to "entity_reference". This initially caused that this FeedsTarget got used for all entity reference fields. To fix this, I overrided the method targets() to return only targets when the field's target type is "taxonomy_term".
This doesn't look like the best solution, because first the FeedsTarget "entity_reference" will register targets for all fields of type "entity_reference" and later on the FeedsTarget "taxonomy" will override the targets for fields that reference taxonomy terms, but only because "Taxonomy" is later in the alphabet than "EntityReference". I can imagine that contributed modules specifying their own entity type, sometimes want to provide specific options for referencing entities as well. Is there a better method of overriding already defined targets by an other FeedsTarget?

Details of the changes in the patch and their reasoning:

\Drupal\feeds\Feeds\Target\EntityReference:
- Method getBundle() is changed into getBundles, because entitiy references now can target multiple bundles.
\Drupal\feeds\Feeds\Target\Taxonomy:
- Bind to field type "entity_reference".
- Overrides \Drupal\feeds\Plugin\Type\Target\FieldTargetBase::targets() to only return targets when the field's target type is "taxonomy_term".
- When the "autocreate" option is enabled and the entity reference is set to target multiple bundles, a term will be created for the first bundle only. This is also how it works in core now, though that may change. See #2412569: Allow setting the auto-create bundle on entity reference fields with multiple target bundles.
The test \Drupal\feeds\Tests\Feeds\RssNodeImport passes localy.

Comment #2

twistor CreditAttribution: twistor commented 23 April 2015 at 17:17

Could we just move the auto creation to the entity reference target and remove the taxonomy target?

Comment #3

23 April 2015 at 21:08

twistor committed 69c87b3 on 8.x-3.x

Issue #2476115 by MegaChriz: Restore the Taxonomy mapper

Comment #4

twistor CreditAttribution: twistor commented 23 April 2015 at 21:08

Status:

Needs review

» Fixed

Comment #5

23 April 2015 at 22:05

Status:

Fixed

» Needs work

The last submitted patch, 1: feeds-taxonomy-mapper-2476115-1.patch, failed testing.

Comment #6

MegaChriz CreditAttribution: MegaChriz commented 24 April 2015 at 07:30

Status:

Needs work

» Fixed

@twistor
The auto creation will not work for every entity type, because some entities may require more values than just the label.

Leaving state to "needs work" for now. Feel free to set the issue back to "fixed" if the concern above does not apply. I haven't tested the module yet with the latest changes.