Problem/Motivation

Calls to httprl_queue_background_callback() with only a single $arg value passed to it, like linkchecker does in its hook_cron always fail. This is because calls to httprl_async_page() get a serialized empty array 'a:0:{}', which is equal to FALSE when using only '=='. See #2374945: workaround unserialize errors where this logic was introduced.

Proposed resolution

The check for a serialized failure is a little too loose. Let's tighten it up a little and do a strict equality check here.

Remaining tasks

Review patch

User interface changes

n/a

API changes

n/a

CommentFileSizeAuthor
#1 httprl-batch_failures-2475421-1.patch1.4 KBheddn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Status: Active » Needs review
FileSize
httprl-batch_failures-2475421-1.patch1.4 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Title: httprl_queue_background_callback with NULL &$result always fails » httprl_queue_background_callback with &$result = NULL always fails
hass’s picture

hass CreditAttribution: hass commented
Priority: Normal » Critical

Breaks linkchecker integration for unknown reasons.

  • mikeytown2 committed b751040 on 6.x-1.x authored by heddn 
    Issue #2475421 by heddn: httprl_queue_background_callback with...
  • mikeytown2 committed 26382f9 on 7.x-1.x authored by heddn
    Issue #2475421 by heddn: httprl_queue_background_callback with...
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Needs review » Fixed

Thanks for the patch, it has been committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.